fix: thread toast duration through session hook config

kecsap · kecsap · commit 21db026d1713 · 2026-06-15T12:51:37.000+02:00
- preserves toast_duration_ms when building the narrowed hook config
- keeps dream notifications on the configured duration instead of falling back to 5s
- includes regression coverage
- keep restart/setup toasts on 10s fallback
diff --git a/CONFIGURATION.md b/CONFIGURATION.md
@@ -113,6 +113,7 @@ Higher-tier models with longer cache windows benefit from a longer TTL. Setting
 | `ctx_reduce_enabled` | `boolean` | `true` | When `false`, hides `ctx_reduce` tool, disables all nudges/reminders, and strips reduction guidance from prompts. Heuristic cleanup, compartments, memory, and search still work. Useful for testing whether automatic cleanup alone is sufficient. |
 | `cache_ttl` | `string` or `object` | `"5m"` | Time after a response before applying pending ops. String or per-model map. |
 | `protected_tags` | `number` (1–100) | `20` | Last N active tags immune from immediate dropping. |
+| `toast_duration_ms` | `number` (1000–60000) | `5000` | TUI toast lifetime for Magic Context notifications in milliseconds. Increase this if toasts disappear too quickly. |
 | `execute_threshold_percentage` | `number` (20–80) or `object` | `65` | Context usage that forces queued ops to execute. Capped at 80% max for cache safety. Supports per-model map. |
 | `execute_threshold_tokens` | `object` (per-model map) | — | **Optional absolute-tokens variant of `execute_threshold_percentage`.** Per-model map (e.g. `{ "default": 150000, "github-copilot/gpt-5.2-codex": 40000 }`). When set for a model, overrides the percentage-based threshold for that model. Clamped to `80% × context_limit` with a warn log. Requires a resolvable context limit — falls through to percentage if unavailable. See below. |
 | `clear_reasoning_age` | `number` | `50` | Clear thinking/reasoning blocks older than N tags. |
@@ -627,6 +628,7 @@ Tier boundaries are hardcoded to keep behavior predictable and prevent cache-bus
     "anthropic/claude-opus-4-6": 50
   },
   "protected_tags": 10,
+  "toast_duration_ms": 12000,
   "history_budget_percentage": 0.15,
   "temporal_awareness": true,
 
diff --git a/assets/magic-context.schema.json b/assets/magic-context.schema.json
@@ -461,6 +461,13 @@
         }
       ]
     },
+    "toast_duration_ms": {
+      "default": 5000,
+      "description": "TUI toast lifetime in milliseconds for Magic Context notifications (min: 1000, max: 60000, default: 5000)",
+      "type": "number",
+      "minimum": 1000,
+      "maximum": 60000
+    },
     "execute_threshold_percentage": {
       "default": 65,
       "description": "Context percentage that forces queued operations to execute. Number or per-model object ({ default: 65, \"provider/model\": 45 }). Values above 80 are rejected because the runtime caps at 80% for cache safety (MAX_EXECUTE_THRESHOLD). Default: DEFAULT_EXECUTE_THRESHOLD_PERCENTAGE",
diff --git a/packages/dashboard/src/components/ConfigEditor/ConfigEditor.tsx b/packages/dashboard/src/components/ConfigEditor/ConfigEditor.tsx
@@ -204,6 +204,13 @@ const FIELD_DEFS: FieldDef[] = [
       "Enable agent-controlled reductions via the ctx_reduce tool. When enabled, the agent is prompted and nudged to choose what messages and tool calls to drop. When disabled, the system still manages context automatically via historian comparting and the tiered emergency drop under pressure.",
     section: "General",
   },
+  {
+    key: "toast_duration_ms",
+    label: "Toast Duration (ms)",
+    type: "number",
+    description: "How long Magic Context TUI toasts stay visible.",
+    section: "General",
+  },
   // Thresholds
   // cache_ttl and execute_threshold_percentage are rendered as custom PerModelField components
   // Tags & cleanup
diff --git a/packages/dashboard/src/components/ConfigEditor/config-field-coverage.ts b/packages/dashboard/src/components/ConfigEditor/config-field-coverage.ts
@@ -20,6 +20,7 @@ export const RENDERED_PREFIXES: readonly string[] = [
   // General
   "enabled",
   "ctx_reduce_enabled",
+  "toast_duration_ms",
   // Thresholds (custom PerModelField widgets)
   "cache_ttl",
   "execute_threshold_percentage",
diff --git a/packages/plugin/src/config/schema/magic-context.test.ts b/packages/plugin/src/config/schema/magic-context.test.ts
@@ -43,6 +43,7 @@ describe("MagicContextConfigSchema", () => {
                 enabled: true,
                 auto_update: false,
                 ctx_reduce_enabled: true,
+                toast_duration_ms: 5000,
                 cache_ttl: "10m",
                 protected_tags: 3,
                 execute_threshold_percentage: 75,
diff --git a/packages/plugin/src/config/schema/magic-context.ts b/packages/plugin/src/config/schema/magic-context.ts
@@ -244,6 +244,8 @@ export interface MagicContextConfig {
     historian?: HistorianConfig;
     dreamer?: DreamerConfig;
     cache_ttl: string | { default: string; [modelKey: string]: string };
+    /** TUI toast lifetime in milliseconds for Magic Context notifications. Default: 5000. */
+    toast_duration_ms?: number;
     execute_threshold_percentage: number | { default: number; [modelKey: string]: number };
     /** Absolute token thresholds per model. When set for a given model (or via `default`),
      *  this overrides `execute_threshold_percentage` for that model. Useful for hard caps
@@ -374,6 +376,14 @@ export const MagicContextConfigSchema = z
             .describe(
                 'Cache TTL: string (e.g. "5m") or per-model object ({ default: "5m", "model-id": "10m" })',
             ),
+        toast_duration_ms: z
+            .number()
+            .min(1_000)
+            .max(60_000)
+            .default(5_000)
+            .describe(
+                "TUI toast lifetime in milliseconds for Magic Context notifications (min: 1000, max: 60000, default: 5000)",
+            ),
         execute_threshold_percentage: z
             .union([
                 z.number().min(20).max(80, EXECUTE_THRESHOLD_CAP_MESSAGE),
diff --git a/packages/plugin/src/hooks/magic-context/command-handler.test.ts b/packages/plugin/src/hooks/magic-context/command-handler.test.ts
@@ -721,13 +721,13 @@ describe("createMagicContextCommandHandler", () => {
                 1,
                 "ses-dream",
                 "Starting dream run...",
-                {},
+                { toastDurationMs: 5000 },
             );
             expect(sendNotification).toHaveBeenNthCalledWith(
                 2,
                 "ses-dream",
                 expect.stringContaining("### Tasks"),
-                {},
+                { toastDurationMs: 5000 },
             );
         });
 
@@ -775,7 +775,7 @@ describe("createMagicContextCommandHandler", () => {
                 3,
                 "ses-dream",
                 "Dream already queued for this project",
-                {},
+                { toastDurationMs: 5000 },
             );
             expect(executeDream).toHaveBeenCalledTimes(1);
         });
diff --git a/packages/plugin/src/hooks/magic-context/command-handler.ts b/packages/plugin/src/hooks/magic-context/command-handler.ts
@@ -270,6 +270,7 @@ async function executeDreaming(
             text: string,
             params: NotificationParams,
         ) => Promise<void>;
+        toastDurationMs?: number;
         dreamer?: {
             config: DreamerConfig;
             projectPath: string;
@@ -288,11 +289,15 @@ async function executeDreaming(
     },
     sessionId: string,
 ): Promise<never> {
+    const dreamNotificationParams: NotificationParams = {
+        toastDurationMs: deps.toastDurationMs ?? 5000,
+    };
+
     if (!deps.dreamer?.config?.tasks?.length) {
         await deps.sendNotification(
             sessionId,
             "## /ctx-dream\n\nDreaming is not configured for this project.",
-            {},
+            dreamNotificationParams,
         );
         throwSentinel("CTX-DREAM");
     }
@@ -303,11 +308,15 @@ async function executeDreaming(
     // runner with an unexpired lease is never deleted just because it is older than 2m.
     const entry = enqueueDream(deps.db, deps.dreamer.projectPath, "manual", true);
     if (!entry) {
-        await deps.sendNotification(sessionId, "Dream already queued for this project", {});
+        await deps.sendNotification(
+            sessionId,
+            "Dream already queued for this project",
+            dreamNotificationParams,
+        );
         throwSentinel("CTX-DREAM");
     }
 
-    await deps.sendNotification(sessionId, "Starting dream run...", {});
+    await deps.sendNotification(sessionId, "Starting dream run...", dreamNotificationParams);
 
     const result = deps.dreamer.executeDream
         ? await deps.dreamer.executeDream(sessionId)
@@ -334,7 +343,7 @@ async function executeDreaming(
         result
             ? summarizeDreamResult(result)
             : "Dream queued, but another worker is already processing the queue.",
-        {},
+        dreamNotificationParams,
     );
     throwSentinel("CTX-DREAM");
 }
@@ -371,6 +380,8 @@ export function createMagicContextCommandHandler(deps: {
         text: string,
         params: NotificationParams,
     ) => Promise<void>;
+    /** Configured toast lifetime (ms) forwarded into diagnostics logs. */
+    toastDurationMs?: number;
     sidekick?: {
         config: SidekickConfig;
         projectPath: string;
diff --git a/packages/plugin/src/hooks/magic-context/hook-handlers.ts b/packages/plugin/src/hooks/magic-context/hook-handlers.ts
@@ -130,11 +130,13 @@ export function getLiveNotificationParams(
     liveModelBySession: LiveModelBySession,
     variantBySession: VariantBySession,
     agentBySession?: AgentBySession,
+    toastDurationMs?: number,
 ): {
     agent?: string;
     variant?: string;
     providerId?: string;
     modelId?: string;
+    toastDurationMs?: number;
 } {
     const model = liveModelBySession.get(sessionId);
     const variant = variantBySession.get(sessionId);
@@ -143,6 +145,7 @@ export function getLiveNotificationParams(
         ...(agent ? { agent } : {}),
         ...(variant ? { variant } : {}),
         ...(model ? { providerId: model.providerID, modelId: model.modelID } : {}),
+        ...(typeof toastDurationMs === "number" ? { toastDurationMs } : {}),
     };
 }
 
diff --git a/packages/plugin/src/hooks/magic-context/hook.ts b/packages/plugin/src/hooks/magic-context/hook.ts
@@ -84,6 +84,7 @@ export interface MagicContextDeps {
     config: {
         protected_tags: number;
         ctx_reduce_enabled?: boolean;
+        toast_duration_ms?: number;
         clear_reasoning_age?: number;
         execute_threshold_percentage?: number | { default: number; [modelKey: string]: number };
         execute_threshold_tokens?: { default?: number; [modelKey: string]: number | undefined };
@@ -338,7 +339,13 @@ export function createMagicContextHook(deps: MagicContextDeps) {
         userMemoriesEnabled: dreamerConfig?.user_memories?.enabled === true,
         ensureProjectRegistered: ensureProjectRegisteredFromOpenCodeDirectory,
         getNotificationParams: (sid) =>
-            getLiveNotificationParams(sid, liveModelBySession, variantBySession, agentBySession),
+            getLiveNotificationParams(
+                sid,
+                liveModelBySession,
+                variantBySession,
+                agentBySession,
+                deps.config.toast_duration_ms,
+            ),
     });
     // /ctx-embed-history: backfill ALL of this session's compartment chunk
     // embeddings in one pass, reusing the recomp progress surface (sidebar +
@@ -453,6 +460,7 @@ export function createMagicContextHook(deps: MagicContextDeps) {
                 liveModelBySession,
                 variantBySession,
                 agentBySession,
+                deps.config.toast_duration_ms,
             ),
         getModelKey: (sessionId) => {
             const model = liveModelBySession.get(sessionId);
@@ -509,6 +517,7 @@ export function createMagicContextHook(deps: MagicContextDeps) {
                 liveModelBySession,
                 variantBySession,
                 agentBySession,
+                deps.config.toast_duration_ms,
             ),
         onSessionCacheInvalidated: (sessionId: string) => {
             clearInjectionCache(sessionId);
@@ -588,6 +597,7 @@ export function createMagicContextHook(deps: MagicContextDeps) {
     const commandHandler = createMagicContextCommandHandler({
         db,
         protectedTags: deps.config.protected_tags,
+        toastDurationMs: deps.config.toast_duration_ms,
         executeThresholdPercentage: deps.config.execute_threshold_percentage ?? 65,
         executeThresholdTokens: deps.config.execute_threshold_tokens,
         historyBudgetPercentage: deps.config.history_budget_percentage,
@@ -639,6 +649,7 @@ export function createMagicContextHook(deps: MagicContextDeps) {
                     liveModelBySession,
                     variantBySession,
                     agentBySession,
+                    deps.config.toast_duration_ms,
                 ),
                 ...params,
             });
@@ -763,6 +774,7 @@ export function createMagicContextHook(deps: MagicContextDeps) {
                                       liveModelBySession,
                                       variantBySession,
                                       agentBySession,
+                                      deps.config.toast_duration_ms,
                                   ),
                               isTuiConnected,
                               pushTuiDialogAction: (sid, resume) =>
diff --git a/packages/plugin/src/hooks/magic-context/send-session-notification.ts b/packages/plugin/src/hooks/magic-context/send-session-notification.ts
@@ -6,6 +6,8 @@ export interface NotificationParams {
     variant?: string;
     providerId?: string;
     modelId?: string;
+    /** TUI toast lifetime in milliseconds (default: 5000). */
+    toastDurationMs?: number;
 }
 
 export type NotificationDeliveryDisposition = "sent" | "skipped" | "failed";
@@ -71,31 +73,32 @@ export async function sendIgnoredMessage(
     // is too easy to miss — dogfood 2026-05-30.
     forcePersist = false,
 ): Promise<NotificationDeliveryDisposition> {
+    const title = extractToastTitle(text);
+    const message = text.length > 200 ? `${text.slice(0, 200)}…` : text;
+    const toastVariant = inferToastVariant(text);
+    const duration = params.toastDurationMs ?? 5000;
+
     // In TUI mode, show as toast via RPC instead of ignored message — UNLESS the
     // caller asked to force-persist (long-running outcome must stay in scrollback).
     // Cannot use process.env.OPENCODE_CLIENT — it's undefined in the server plugin process.
     const { isTuiConnected: checkTui } = await import("../../shared/rpc-notifications");
     if (!forcePersist && checkTui(sessionId)) {
         try {
-            const c = client as Record<string, unknown>;
-            const tui = c?.tui as Record<string, unknown> | undefined;
-            if (typeof tui?.showToast === "function") {
-                // Intentional: call via property access to preserve `this` binding on the SDK client.
-                // The tui object is an SDK-generated client where methods live on the prototype.
-                const tuiClient = tui as Record<string, (...args: unknown[]) => Promise<unknown>>;
-                await tuiClient.showToast({
-                    body: {
-                        title: extractToastTitle(text),
-                        message: text.length > 200 ? `${text.slice(0, 200)}…` : text,
-                        variant: inferToastVariant(text),
-                        duration: 5000,
-                    },
-                });
-                return "sent";
-            }
+            const { pushNotification } = await import("../../shared/rpc-notifications");
+            pushNotification(
+                "toast",
+                {
+                    title,
+                    message,
+                    variant: toastVariant,
+                    duration,
+                },
+                sessionId,
+            );
+            return "sent";
         } catch {
-            // showToast failed or tui client is unavailable — fall through to ignored message.
-            sessionLog(sessionId, "TUI showToast failed, falling back to ignored message");
+            // RPC enqueue failed — fall through to ignored message.
+            sessionLog(sessionId, "TUI RPC toast enqueue failed, falling back to ignored message");
         }
     }
     // Title-safety guard (issue #129): an ignored message is hidden from the
diff --git a/packages/plugin/src/plugin/hooks/create-session-hooks.test.ts b/packages/plugin/src/plugin/hooks/create-session-hooks.test.ts
@@ -0,0 +1,43 @@
+/// <reference types="bun-types" />
+
+import { beforeEach, describe, expect, it, mock } from "bun:test";
+
+const createMagicContextHookMock = mock(() => ({ mocked: true }));
+
+mock.module("../../hooks/magic-context", () => ({
+    createMagicContextHook: createMagicContextHookMock,
+}));
+
+describe("createSessionHooks", () => {
+    beforeEach(() => {
+        createMagicContextHookMock.mockClear();
+    });
+
+    it("threads notification config into the magic-context hook", async () => {
+        const { createSessionHooks } = await import("./create-session-hooks");
+
+        createSessionHooks({
+            ctx: {
+                client: {},
+                directory: "/tmp/project",
+            } as never,
+            liveSessionState: {
+                liveModelBySession: new Map(),
+                variantBySession: new Map(),
+                agentBySession: new Map(),
+            },
+            pluginConfig: {
+                enabled: true,
+                protected_tags: 10,
+                cache_ttl: "5m",
+                toast_duration_ms: 30_000,
+            } as never,
+        });
+
+        expect(createMagicContextHookMock).toHaveBeenCalledTimes(1);
+        const args = createMagicContextHookMock.mock.calls[0]?.[0] as {
+            config?: { toast_duration_ms?: number };
+        };
+        expect(args.config?.toast_duration_ms).toBe(30_000);
+    });
+});
diff --git a/packages/plugin/src/plugin/hooks/create-session-hooks.ts b/packages/plugin/src/plugin/hooks/create-session-hooks.ts
@@ -44,6 +44,7 @@ export function createSessionHooks(args: {
                 ctx_reduce_enabled: pluginConfig.ctx_reduce_enabled,
                 cache_ttl: pluginConfig.cache_ttl,
                 clear_reasoning_age: pluginConfig.clear_reasoning_age,
+                toast_duration_ms: pluginConfig.toast_duration_ms,
                 execute_threshold_percentage:
                     pluginConfig.execute_threshold_percentage ??
                     DEFAULT_EXECUTE_THRESHOLD_PERCENTAGE,
diff --git a/packages/plugin/src/plugin/rpc-handlers.ts b/packages/plugin/src/plugin/rpc-handlers.ts
diff --git a/packages/plugin/src/shared/rpc-types.ts b/packages/plugin/src/shared/rpc-types.ts
diff --git a/packages/plugin/src/tui/data/context-db.ts b/packages/plugin/src/tui/data/context-db.ts
diff --git a/packages/plugin/src/tui/index.tsx b/packages/plugin/src/tui/index.tsx

Original file line number	Diff line number	Diff line change
`@@ -461,6 +461,13 @@`
`461`	`461`	`}`
`462`	`462`	`]`
`463`	`463`	`},`
	`464`	`+ "toast_duration_ms": {`
	`465`	`+ "default": 5000,`
	`466`	`+ "description": "TUI toast lifetime in milliseconds for Magic Context notifications (min: 1000, max: 60000, default: 5000)",`
	`467`	`+ "type": "number",`
	`468`	`+ "minimum": 1000,`
	`469`	`+ "maximum": 60000`
	`470`	`+ },`
`464`	`471`	`"execute_threshold_percentage": {`
`465`	`472`	`"default": 65,`
`466`	`473`	`"description": "Context percentage that forces queued operations to execute. Number or per-model object ({ default: 65, \"provider/model\": 45 }). Values above 80 are rejected because the runtime caps at 80% for cache safety (MAX_EXECUTE_THRESHOLD). Default: DEFAULT_EXECUTE_THRESHOLD_PERCENTAGE",`