fix panic on health check failure when using stream push #7116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
fix-panic-in-pushStream
branch
from
8ffe20b to
44c7a06
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
fix-panic-in-pushStream
branch
from
44c7a06 to
381352f
Compare
Contributor
|
@alexqyle @danielblando Can you help take a look? |
Contributor
|
This change is worth cherry pick into 1.20 release and we created a new patch |
SungJin1212
added a commit
to SungJin1212/cortex
that referenced
this pull request
Dec 3, 2025
…ct#7116) Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
added a commit
to SungJin1212/cortex
that referenced
this pull request
Dec 3, 2025
…ct#7116) Signed-off-by: SungJin1212 <[email protected]>
yeya24
pushed a commit
that referenced
this pull request
Dec 3, 2025
* fix panic on health check failure when using stream push (#7116) Signed-off-by: SungJin1212 <[email protected]> * prepare release 1.20.1 Signed-off-by: SungJin1212 <[email protected]> --------- Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
added a commit
to SungJin1212/cortex
that referenced
this pull request
Dec 4, 2025
* fix panic on health check failure when using stream push (cortexproject#7116) Signed-off-by: SungJin1212 <[email protected]> * prepare release 1.20.1 Signed-off-by: SungJin1212 <[email protected]> --------- Signed-off-by: SungJin1212 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a panic would be occur in below scenario, and added test case to show it.
This PR adds channel close check logic to prevent the panic.
Scenario
closableHealthAndIngesterClient.Close()calledstreamPushChanclosedcase job := <-c.streamPushChanerr = stream.Send(job.req)Related logs:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]