Skip to content

Commit 1a7ffe1

Browse files
authored
fix: add ics4 wrapper (channel keeper) to icahost (#2924)
1 parent 18a85d6 commit 1a7ffe1

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

app/keepers/keepers.go

+5-10
Original file line numberDiff line numberDiff line change
@@ -350,8 +350,7 @@ func NewAppKeeper(
350350
appCodec,
351351
appKeepers.keys[icahosttypes.StoreKey],
352352
appKeepers.GetSubspace(icahosttypes.SubModuleName),
353-
// TODO: Pass FeeKeeper as ics4Wrapper if enabled
354-
nil,
353+
appKeepers.IBCKeeper.ChannelKeeper, // ICS4Wrapper
355354
appKeepers.IBCKeeper.ChannelKeeper,
356355
&appKeepers.IBCKeeper.PortKeeper,
357356
appKeepers.AccountKeeper,
@@ -386,12 +385,9 @@ func NewAppKeeper(
386385
// Must be called on PFMRouter AFTER TransferKeeper initialized
387386
appKeepers.PFMRouterKeeper.SetTransferKeeper(appKeepers.TransferKeeper)
388387

389-
// Create IBC Router
390-
ibcRouter := porttypes.NewRouter()
391-
392388
// Middleware Stacks
393-
appKeepers.TransferModule = transfer.NewAppModule(appKeepers.TransferKeeper)
394389
appKeepers.ICAModule = ica.NewAppModule(nil, &appKeepers.ICAHostKeeper)
390+
appKeepers.TransferModule = transfer.NewAppModule(appKeepers.TransferKeeper)
395391
appKeepers.PFMRouterModule = pfmrouter.NewAppModule(appKeepers.PFMRouterKeeper, appKeepers.GetSubspace(pfmroutertypes.ModuleName))
396392

397393
// create IBC module from bottom to top of stack
@@ -406,17 +402,16 @@ func NewAppKeeper(
406402
)
407403

408404
// Add transfer stack to IBC Router
409-
ibcRouter.AddRoute(ibctransfertypes.ModuleName, transferStack)
410405

411406
// Create Interchain Accounts Stack
412407
var icaHostStack porttypes.IBCModule = icahost.NewIBCModule(appKeepers.ICAHostKeeper)
413408

414-
// create static IBC router, add transfer route, then set and seal it
415-
ibcRouter.
409+
// Create IBC Router & seal
410+
ibcRouter := porttypes.NewRouter().
416411
AddRoute(icahosttypes.SubModuleName, icaHostStack).
412+
AddRoute(ibctransfertypes.ModuleName, transferStack).
417413
AddRoute(providertypes.ModuleName, appKeepers.ProviderModule)
418414

419-
// Seal the IBC Router
420415
appKeepers.IBCKeeper.SetRouter(ibcRouter)
421416

422417
return appKeepers

0 commit comments

Comments
 (0)