-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify text format for invalid/unexpected value errors #334
Labels
good first issue
Good for newcomers
Comments
9 tasks
faddat
pushed a commit
to notional-labs/ibc-go
that referenced
this issue
Mar 1, 2022
handshake refactor
3 tasks
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this issue
Nov 6, 2023
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.0 to 1.7.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.0...v1.7.1) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hello @crodriguezvega , I would like to do this if this is still needed. Can you assign me this issue? |
Sorry for the late reply, @iricehasan. I hope you're still interested in the issue, I will assign it to you now. |
Hi @crodriguezvega, I have just seen your reply. I am still interested. |
Merged
12 tasks
10 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The error message for an invalid value is formatted in slightly different ways. Take the following three as an example:
"expected %s channel, got %s "
(https://github.com/cosmos/ibc-go/blob/main/modules/apps/transfer/module.go#L207)"invalid port: %s, expected %s"
(https://github.com/cosmos/ibc-go/blob/main/modules/apps/transfer/module.go#L213)"got %s, expected %s"
(https://github.com/cosmos/ibc-go/blob/main/modules/apps/transfer/module.go#L217)The goal is to format this kind of errors in a consistent way.
The proposal is to do the following:
For Admin Use
The text was updated successfully, but these errors were encountered: