Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ValidateBasic function for packetV2 #7255

Closed
bznein opened this issue Sep 5, 2024 · 2 comments
Closed

Implement ValidateBasic function for packetV2 #7255

bznein opened this issue Sep 5, 2024 · 2 comments

Comments

@bznein
Copy link
Contributor

bznein commented Sep 5, 2024

in packet-server's SendPacket, after #7254 is merged

@chandiniv1
Copy link
Contributor

@bznein can I work on this issue?

@bznein
Copy link
Contributor Author

bznein commented Oct 23, 2024

Hi @chandiniv1 apologies but this has actually be already done (https://github.com/cosmos/ibc-go/blob/feat/ibc-eureka/modules/core/04-channel/v2/types/packet.go#L34-L61) and whoever worked on it forgot to close the issue

@bznein bznein closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

No branches or pull requests

3 participants