chore(testing): remove redundant UpdateClient call in MsgSendPacketWithSender #8652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8652 +/- ##
=======================================
Coverage 58.31% 58.31%
=======================================
Files 319 319
Lines 22821 22821
=======================================
Hits 13307 13307
Misses 8907 8907
Partials 607 607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
srdtrk
changed the title
srdtrk
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a duplicate ep.Counterparty.UpdateClient() call after SendMsgsWithSender. Only a single client update is needed post-state change; the second update was a no-op (duplicate header) and inconsistent with surrounding patterns in v1/v2 endpoints. This change reduces unnecessary work and aligns with documented no-op semantics for duplicate client updates.