PCBC-646: Fixed issue with blank string decoding.

Change-Id: I8ae2ed85b16450ba818af359b31e6714827d19a8
Reviewed-on: http://review.couchbase.org/117410
Tested-by: Build Bot <[email protected]>
Reviewed-by: Sergey Avseyev <[email protected]>

Author: brett19

src/couchbase/document.c

@@ -42,7 +42,7 @@ void pcbc_document_init_decode(zval *return_value, pcbc_bucket_t *bucket, const
 {
     object_init_ex(return_value, pcbc_document_ce);
 
-    if (bytes_len) {
+    {
         PCBC_ZVAL val;
         PCBC_ZVAL_ALLOC(val);
         pcbc_decode_value(PCBC_P(val), bucket, bytes, bytes_len, flags, datatype TSRMLS_CC);

tests/BucketTest.php

@@ -92,6 +92,36 @@ function testBasicRemove($b, $key) {
         }, '\Couchbase\Exception', COUCHBASE_KEYNOTFOUND);
     }
 
+    /**
+     * Test blank string storage and retrieval
+     *
+     * @depends testConnect
+     */
+    function testBlankStringTrans($b) {
+        $key = $this->makeKey('blankStringTrans');
+
+        $res = $b->upsert($key, '');
+        $this->assertValidMetaDoc($res, 'cas');
+
+        $res = $b->get($key);
+        $this->assertValidMetaDoc($res, 'cas', 'flags');
+        $this->assertEquals($res->value, '');
+    }
+
+    /**
+     * Test handing NULL values
+     *
+     * @depends testConnect
+     */
+    function testEmptyNullValues($b) {
+        $key = $this->makeKey('nullValue');
+        $res = $b->upsert($key, null);
+        $this->assertValidMetaDoc($res, 'cas');
+        $res = $b->get($key);
+        $this->assertValidMetaDoc($res, 'cas', 'flags');
+        $this->assertEquals(null, $res->value);
+    }
+
     /**
      * Test multi upsert
      *