Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing portage color into palette.styl #2325

Open
cballevre opened this issue Jan 9, 2023 · 4 comments
Open

Missing portage color into palette.styl #2325

cballevre opened this issue Jan 9, 2023 · 4 comments
Assignees

Comments

@cballevre
Copy link
Member

Into cozy-sharing, we had a problem on sharing badge with me because portage color has been remove from cozy-ui (cc: 5fd473a). As a temporary fix, I hardcoded the color into styl file (cc: cozy/cozy-libs#1957).

Now the question is how to fix it properly ?

Adding it back to palette.styl because the color is still present into palette.json or @JF-Cozy
do you have any other ideas ?

@Crash--
Copy link
Contributor

Crash-- commented Jan 9, 2023

Few related issues: #1860 #1546

@JF-Cozy
Copy link
Collaborator

JF-Cozy commented Jan 9, 2023

Voir la réponse : cozy/cozy-libs#1957 (review)

Est-ce que ce ne sont pas des cas sans spec ou basés sur des composants legacy ?

@Crash--
Copy link
Contributor

Crash-- commented Jan 10, 2023

Si et on va supprimer cette dite valeur dans pas longtemps. Mais, reste que portage est défini dans la palette.json

"portage": "#9169F2",
mais qu'elle n'est pas présente dans la palette.styl https://github.com/cozy/cozy-ui/blob/2746d0f5e7223f736586f73f7dca1d7f7ec54af3/stylus/settings/palette.styl

Et j'ai perdu le fil de ce qu'on faisait de ces 2 palettes et qu'elle était la vision sur ce sujet.

@Crash--
Copy link
Contributor

Crash-- commented Mar 1, 2023

@cballevre I found the way to fix that correctly: cozy/cozy-libs#2041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants