Fix when native binary exists (#43)

* fix: download binary when native binary exist #37

* fix: pre-commit run --all-files

* fix: let specific version pass test

* docs: remove 12.0.1 out of readme

* update workflow and pass Codecov

Author: shenxianpeng

.github/workflows/python-test.yml

@@ -4,11 +4,6 @@
 name: Test
 
 on:
-  push:
-    # branches: [ "main" ]
-    paths:
-      - '**.py'
-      - '.github/workflows/python-test.yml'
   pull_request:
     branches: [ "main" ]
   workflow_dispatch:
@@ -29,8 +24,8 @@ jobs:
         run: |
           python3 -m pip install --upgrade pip
           python3 -m pip install . -r requirements-dev.txt
-
-      - run: pre-commit run
+      - name: Run pre-commit
+        run: pre-commit run --all-files
 
       - name: Collect coverage
         run: |
@@ -81,26 +76,45 @@ jobs:
       - name: Install clang-tools
         run: clang-tools --install ${{ matrix.version }}
 
-      - name: show path of binaries
+      - name: Show path of binaries
         shell: bash
         run: |
-          which clang-format-${{ matrix.version }}
-          which clang-tidy-${{ matrix.version }}
+          if [ "${{ matrix.version }}" = "15" -a "${{ matrix.os }}" = "windows-latest" ]; then
+            which clang-format
+            which clang-tidy
+          elif [ "${{ matrix.version }}" = "12.0.1"  -a "${{ matrix.os }}" = "ubuntu-latest" ]; then
+            which clang-format-12
+            which clang-tidy-12
+          else
+            which clang-format-${{ matrix.version }}
+            which clang-tidy-${{ matrix.version }}
+          fi
 
       - name: Check clang-tools on Windows
         if: matrix.os == 'windows-latest'
+        shell: bash
         run: |
-          clang-format-${{ matrix.version }}.exe --version
-          clang-tidy-${{ matrix.version }}.exe --version
+          if [ "${{ matrix.version }}" = "15" ]; then
+            clang-format.exe --version
+            clang-tidy.exe --version
+          else
+            clang-format-${{ matrix.version }}.exe --version
+            clang-tidy-${{ matrix.version }}.exe --version
+          fi
 
       - name: Check clang-tools on Unix
         if: matrix.os == 'ubuntu-latest' || matrix.os == 'macos-latest'
         run: |
-          clang-format-${{ matrix.version }} --version
-          if [ "${{ matrix.version }}" = "14" -o "${{ matrix.version }}" = "15" ]; then
-            echo "skip version ${{ matrix.version }} because Segmentation fault on ubuntu."
+          if [ "${{ matrix.version }}" = "12.0.1" -a "${{ matrix.os }}" = "ubuntu-latest" ]; then
+            clang-format-12 --version
+            clang-tidy-12 --version
           else
-            clang-tidy-${{ matrix.version }} --version
+            clang-format-${{ matrix.version }} --version
+            if [ "${{ matrix.version }}" = "14" -o "${{ matrix.version }}" = "15" ]; then
+              echo "skip version ${{ matrix.version }} because Segmentation fault on ubuntu."
+            else
+              clang-tidy-${{ matrix.version }} --version
+            fi
           fi
 
   docs:

.gitignore

@@ -13,4 +13,4 @@ tests/__pycache__/
 .eggs
 .mypy_cache/
 *env
-docs/cli_args.rst
+docs/cli_args.rst

README.rst

@@ -124,22 +124,22 @@ Supported versions
 clang-format
 ************
 .. csv-table::
-    :header: "Version", "15", "14", "13", "12.0.1", "12", "11", "10", "9", "8", "7", "6", "5", "4", "3.9"
+    :header: "Version", "15", "14", "13", "12", "11", "10", "9", "8", "7", "6", "5", "4", "3.9"
     :stub-columns: 1
 
-    Linux,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
-    Windows,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
-    macOS,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    Linux,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    Windows,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    macOS,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
 
 clang-tidy
 **********
 .. csv-table::
-    :header: "Version", "15", "14", "13", "12.0.1", "12", "11", "10", "9", "8", "7", "6", "5", "4", "3.9"
+    :header: "Version", "15", "14", "13", "12", "11", "10", "9", "8", "7", "6", "5", "4", "3.9"
     :stub-columns: 1
 
-    Linux,❌,❌,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
-    Windows,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
-    macOS,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    Linux,❌,❌,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    Windows,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    macOS,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
 
 Know issues:
 

clang_tools/install.py

@@ -54,9 +54,9 @@ def is_installed(tool_name: str, version: str) -> Optional[Path]:
         return None  # failed to locate the binary
     path = Path(path).resolve()
     print("at", str(path))
+    ver_num = ver_num.groups(0)[0].decode(encoding="utf-8").split(".")  # pragma: no cover
     if (
-        ver_num is None
-        or ver_num.groups(0)[0].decode(encoding="utf-8").split(".") != version_tuple
+        ver_num is None or ver_num[0] != ver_major
     ):
         return None  # version is unknown or not the desired major release
     return path

clang_tools/main.py

@@ -9,6 +9,7 @@
 from .install import install_clang_tools, uninstall_clang_tools
 from . import RESET_COLOR, YELLOW
 
+
 def get_parser() -> argparse.ArgumentParser:
     """Get and parser to interpret CLI args."""
     parser = argparse.ArgumentParser()

clang_tools/util.py

@@ -13,7 +13,6 @@
 from http.client import HTTPResponse
 
 
-
 def check_install_os() -> str:
     """Identify this Operating System.
 

tests/test_install.py

@@ -64,9 +64,10 @@ def test_install_tools(monkeypatch: pytest.MonkeyPatch, tmp_path: Path, version:
             fd.name for fd in tmp_path.iterdir()
         ]
 
+
 def test_path_warning(capsys: pytest.CaptureFixture):
     """Explicitly fail to download a set of tools to test the prompts that
-    
+
     1. warns users about using a dir not in env var PATH.
     2. indicates a failure to download a tool
     """