unexpected source files has been included

[alfred-green-rand]

What events trigger your workflow?

on:
  pull_request: {}
  workflow_dispatch: {}

What OS does your workflow use?

runs-on: macos-latest

How is cpp-linter-action configured?

- uses: cpp-linter/cpp-linter-action@v2
        id: cpp-linter-format
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          style: 'file'
          extensions: "h,hpp,c,cc,cpp,cxx,m,mm"
          tidy-checks: '-*'
          repo-root: '.'
          version: '18'
          lines-changed-only: false
          files-changed-only: false
          ignore: '|!packing/ios/|!pkg/sdk|!axhttp/ios/'
          format-review: true
          tidy-review: false
          step-summary: true
          thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}

What was the unexpected behavior?

unexpected source files has been included.(for example packing/windows/* should be ignore).

Running cpp-linter
INFO:CPP Linter:Ignoring the following paths/files/patterns:
	./"
INFO:CPP Linter:Not ignoring the following paths/files/patterns:
	./pkg/sdk
	./cpp
	./packing/ios
	./mm
	./axhttp/ios/"
	./cc
	./m
	./hpp
	./cxx
	./c
Get list of specified source files
  INFO:CPP Linter:Giving attention to the following files:
  	packing/windows/AxisApiDemo/stdafx.h
  	packing/windows/AxisApiDemo/winhttp.h
  	packing/windows/AxisApiDemo/define.h
  	packing/windows/AxisApiDemo/IHttpInterface.h
  	packing/windows/AxisApiDemo/HttpClient.h
  	packing/windows/AxisApiDemo/targetver.h
  	packing/windows/AxisApiDemo/Common.h
  	packing/windows/AxisApiDemo/httpHeader.h

Running actions's SHA is below

Download action repository 'cpp-linter/cpp-linter-action@v2' (SHA:0f6d1b8d7e38b584cbee606eb23d850c217d54f8)

Some workflow works well last week.(using v2.15.1)

INFO:CPP Linter:Ignoring the following paths/files/patterns:
	./.
INFO:CPP Linter:Not ignoring the following paths/files/patterns:
	./packing/ios
	./axhttp/ios
	./pkg/sdk
Get list of specified source files
  INFO:CPP Linter:Fetching files list from url: https://api.github.com/repos/cyberandao/sdk/pulls/162
  INFO:CPP Linter:Giving attention to the following files:
  	axhttp/ios/urlsession/oc-urlsession/demo/demo/ViewController.m
  	axhttp/ios/urlsession/oc-urlsession/demo/demo/SceneDelegate.m
  	axhttp/ios/urlsession/oc-urlsession/demo/demo/main.m

Download action repository 'cpp-linter/cpp-linter-action@v2' (SHA:18f74295e9f27f4541a8e9491c10015b48cc4faa)

[shenxianpeng]

It seems to be expected behavior; I am waiting for @2bndy5 's comment.

It looks like the ignore rule needs to be updated from:
ignore: '|!packing/ios/|!pkg/sdk|!axhttp/ios/'
to
ignore: '|!packing/windows/|!packing/ios/|!pkg/sdk|!axhttp/ios/'.

But I have no idea why the output has changed from 0f6d1b8 to 18f7429 (latest)

[2bndy5]

I'm starting to suspect there was some kind of change in the python std lib (pathlib.Path.rglob()). We can roll back the used python version to v3.10 and see if that fixes it. I think the switch to uv (in cpp-linter-action v2.16.0) uses the latest python stable release by default (v3.13 as of this writing).

I could also look at the cpp-linter python source too. But that hasn't changed in over a year.

[2bndy5]

0f6d1b8...18f7429

I suppose it is worth reviewing the nushell script used in action.yml.

[2bndy5]

This will be fixed after #324 is merged and released.

BTW, you can make the ignore option more readable with YAML's >-:

          # ignore all paths except those prefixed with `!`
          ignore: >-
            | ! packing/ios/
            | ! pkg/sdk
            | ! axhttp/ios/

which is equivalent to

          ignore: '| ! packing/ios/ | ! pkg/sdk | ! axhttp/ios/'

The cpp-linter python source will strip spaces both before and after the | and ! (if the path begins with !) characters.