use test profiles

- organize config files into .config/ folder
  only those that do not require repo root location
- minor test improvements

Author: 2bndy5

.readthedocs.yaml renamed to .config/.readthedocs.yaml

@@ -0,0 +1,31 @@
+# required minimum nextest version
+nextest-version = "0.9.77"
+
+[profile.default]
+# A profile to run most tests, except tests that run longer than 10 seconds
+default-filter = "not test(#*rate_limit_secondary) - test(#git::test::with_*)"
+
+# This will flag any test that runs longer than 10 seconds. Useful when writing new tests.
+slow-timeout = "10s"
+
+[profile.ci]
+# A profile to run only tests that use clang-tidy and/or clang-format
+# NOTE: This profile is intended to keep CI runtime low. Locally, use default or all profiles
+
+# This is all tests in tests/ folder + unit test for --extra-args.
+default-filter = "kind(test) + test(#*use_extra_args)"
+
+# show wich tests were skipped
+status-level = "skip"
+
+# show log output from each test
+success-output = "final"
+failure-output = "immediate-final"
+
+[profile.all]
+# A profile to run all tests (including tests that run longer than 10 seconds)
+default-filter = "all()"
+
+# Revert slow-timeout to nextest default value.
+# Otherwise, default profile value (10s) is inherited.
+slow-timeout = "60s"

cliff.toml renamed to .config/cliff.toml

@@ -54,7 +54,7 @@ jobs:
         uses: orhun/git-cliff-action@v4
         id: git-cliff
         with:
-          config: cliff.toml
+          config: .config/cliff.toml
           args: --unreleased
         env:
           OUTPUT: ${{ runner.temp }}/changes.md

.config/nextest.toml

@@ -120,7 +120,16 @@ def main():
     subprocess.run(["napi", "version"], cwd="node-binding", check=True)
     print("Updated version in node-binding/**package.json")
 
-    subprocess.run(["git", "cliff", "--tag", Updater.new_version], check=True)
+    subprocess.run(
+        [
+            "git-cliff",
+            "--config",
+            ".config/cliff.toml",
+            "--tag",
+            Updater.new_version,
+        ],
+        check=True,
+    )
     print("Updated CHANGELOG.md")
 
     subprocess.run(["git", "add", "--all"], check=True)

.github/workflows/bump-n-release.yml

@@ -88,7 +88,7 @@ jobs:
         if: runner.os == 'Linux'
         env:
           CLANG_VERSION: '7'
-        run: just test
+        run: just test ci
 
       - name: Install clang v8
         if: runner.os == 'Linux'
@@ -100,7 +100,7 @@ jobs:
         if: runner.os == 'Linux'
         env:
           CLANG_VERSION: '8'
-        run: just test
+        run: just test ci
 
       - name: Install clang v9
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -110,7 +110,7 @@ jobs:
       - name: Collect Coverage for clang v9
         env:
           CLANG_VERSION: '9'
-        run: just test
+        run: just test ci
 
       - name: Install clang v10
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -120,7 +120,7 @@ jobs:
       - name: Collect Coverage for clang v10
         env:
           CLANG_VERSION: '10'
-        run: just test
+        run: just test ci
 
       - name: Install clang 11
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -130,7 +130,7 @@ jobs:
       - name: Collect Coverage for clang v11
         env:
           CLANG_VERSION: '11'
-        run: just test
+        run: just test ci
 
       - name: Install clang 12
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -140,7 +140,7 @@ jobs:
       - name: Collect Coverage for clang v12
         env:
           CLANG_VERSION: '12'
-        run: just test
+        run: just test ci
 
       - name: Install clang 13
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -150,7 +150,7 @@ jobs:
       - name: Collect Coverage for clang v13
         env:
           CLANG_VERSION: '13'
-        run: just test
+        run: just test ci
 
       - name: Install clang 14
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -160,7 +160,7 @@ jobs:
       - name: Collect Coverage for clang v14
         env:
           CLANG_VERSION: '14'
-        run: just test
+        run: just test ci
 
       - name: Install clang 15
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -170,7 +170,7 @@ jobs:
       - name: Collect Coverage for clang v15
         env:
           CLANG_VERSION: '15'
-        run: just test
+        run: just test ci
 
       - name: Install clang 16
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -180,7 +180,7 @@ jobs:
       - name: Collect Coverage for clang v16
         env:
           CLANG_VERSION: '16'
-        run: just test
+        run: just test ci
 
       - name: Install clang 17
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -190,7 +190,7 @@ jobs:
       - name: Collect Coverage for clang v17
         env:
           CLANG_VERSION: '17'
-        run: just test
+        run: just test ci
 
       - name: Install clang 18
         uses: cpp-linter/cpp_linter_rs/install-clang-action@main
@@ -200,7 +200,7 @@ jobs:
       - name: Collect Coverage for clang v18
         env:
           CLANG_VERSION: '18'
-        run: just test --run-ignored=all
+        run: just test all
 
       - name: Generate Coverage HTML report
         run: just pretty-cov

.github/workflows/bump_version.py

@@ -57,13 +57,15 @@ pub struct Replacement {
     ///
     /// This value is not provided by the XML output, but we calculate it after
     /// deserialization.
-    pub line: Option<usize>,
+    #[serde(default)]
+    pub line: usize,
 
     /// The column number on the line described by the [`Replacement::offset`].
     ///
     /// This value is not provided by the XML output, but we calculate it after
     /// deserialization.
-    pub cols: Option<usize>,
+    #[serde(default)]
+    pub cols: usize,
 }
 
 impl Clone for Replacement {
@@ -188,11 +190,12 @@ pub fn run_clang_format(
         });
     format_advice.patched = patched;
     if !format_advice.replacements.is_empty() {
+        // get line and column numbers from format_advice.offset
         let mut filtered_replacements = Vec::new();
         for replacement in &mut format_advice.replacements {
             let (line_number, columns) = get_line_cols_from_offset(&file.name, replacement.offset);
-            replacement.line = Some(line_number);
-            replacement.cols = Some(columns);
+            replacement.line = line_number;
+            replacement.cols = columns;
             for range in &ranges {
                 if range.contains(&line_number.try_into().unwrap_or(0)) {
                     filtered_replacements.push(replacement.clone());
@@ -233,29 +236,29 @@ mod tests {
                     offset: 113,
                     length: 5,
                     value: Some(String::from("\n      ")),
-                    line: None,
-                    cols: None,
+                    line: 0,
+                    cols: 0,
                 },
                 Replacement {
                     offset: 147,
                     length: 0,
                     value: Some(String::from(" ")),
-                    line: None,
-                    cols: None,
+                    line: 0,
+                    cols: 0,
                 },
                 Replacement {
                     offset: 161,
                     length: 0,
                     value: None,
-                    line: None,
-                    cols: None,
+                    line: 0,
+                    cols: 0,
                 },
                 Replacement {
                     offset: 165,
                     length: 19,
                     value: Some(String::from("\n\n")),
-                    line: None,
-                    cols: None,
+                    line: 0,
+                    cols: 0,
                 },
             ],
             patched: None,

.github/workflows/run-dev-tests.yml

@@ -415,7 +415,6 @@ mod test {
     }
 
     #[tokio::test]
-    #[ignore]
     async fn with_no_changed_sources() {
         // commit with no modified C/C++ sources
         let sha = "0c236809891000b16952576dc34de082d7a40bf3";
@@ -430,7 +429,6 @@ mod test {
     }
 
     #[tokio::test]
-    #[ignore]
     async fn with_changed_sources() {
         // commit with modified C/C++ sources
         let sha = "950ff0b690e1903797c303c5fc8d9f3b52f1d3c5";
@@ -450,7 +448,6 @@ mod test {
     }
 
     #[tokio::test]
-    #[ignore]
     async fn with_staged_changed_sources() {
         // commit with no modified C/C++ sources
         let sha = "0c236809891000b16952576dc34de082d7a40bf3";