add: prefix review comments with marker

Author: 2bndy5

cpp-linter/src/clang_tools/clang_tidy.rs

@@ -318,7 +318,7 @@ pub fn run_clang_tidy(
     )?);
     if clang_params.tidy_review {
         if let Some(tidy_advice) = &mut file.tidy_advice {
-            // cache file changes in a buffer and restore the original contents for further analysis by clang-format
+            // cache file changes in a buffer and restore the original contents for further analysis
             tidy_advice.patched =
                 Some(fs::read(&file_name).with_context(|| {
                     format!("Failed to read changes from clang-tidy: {file_name}")

cpp-linter/src/clang_tools/mod.rs

@@ -95,39 +95,39 @@ fn analyze_single_file(
         .lock()
         .map_err(|_| anyhow!("Failed to lock file mutex"))?;
     let mut logs = vec![];
-    if clang_params.clang_tidy_command.is_some() {
+    if clang_params.clang_format_command.is_some() {
         if clang_params
-            .tidy_filter
+            .format_filter
             .as_ref()
             .is_some_and(|f| f.is_source_or_ignored(file.name.as_path()))
-            || clang_params.tidy_filter.is_none()
+            || clang_params.format_filter.is_none()
         {
-            let tidy_result = run_clang_tidy(&mut file, &clang_params)?;
-            logs.extend(tidy_result);
+            let format_result = run_clang_format(&mut file, &clang_params)?;
+            logs.extend(format_result);
         } else {
             logs.push((
                 log::Level::Info,
                 format!(
-                    "{} not scanned by clang-tidy due to `--ignore-tidy`",
+                    "{} not scanned by clang-format due to `--ignore-format`",
                     file.name.as_os_str().to_string_lossy()
                 ),
             ));
         }
     }
-    if clang_params.clang_format_command.is_some() {
+    if clang_params.clang_tidy_command.is_some() {
         if clang_params
-            .format_filter
+            .tidy_filter
             .as_ref()
             .is_some_and(|f| f.is_source_or_ignored(file.name.as_path()))
-            || clang_params.format_filter.is_none()
+            || clang_params.tidy_filter.is_none()
         {
-            let format_result = run_clang_format(&mut file, &clang_params)?;
-            logs.extend(format_result);
+            let tidy_result = run_clang_tidy(&mut file, &clang_params)?;
+            logs.extend(tidy_result);
         } else {
             logs.push((
                 log::Level::Info,
                 format!(
-                    "{} not scanned by clang-format due to `--ignore-format`",
+                    "{} not scanned by clang-tidy due to `--ignore-tidy`",
                     file.name.as_os_str().to_string_lossy()
                 ),
             ));

cpp-linter/src/cli/mod.rs

@@ -336,13 +336,33 @@ Further filtering can still be applied (see [Source options](#source-options))."
         )
         .groups([
             ArgGroup::new("Clang-tidy options")
-                .args(["tidy-checks", "database", "extra-arg", "ignore-tidy"]).multiple(true),
-            ArgGroup::new("Clang-format options").args(["style", "ignore-format"]).multiple(true),
-            ArgGroup::new("General options").args(["verbosity", "version"]).multiple(true),
-            ArgGroup::new("Source options").args(["extensions", "repo-root", "ignore", "lines-changed-only", "files-changed-only"]).multiple(true),
-            ArgGroup::new("Feedback options").args([
-                "thread-comments", "no-lgtm", "step-summary", "file-annotations", "tidy-review", "format-review", "passive-reviews"
-            ]).multiple(true),
+                .args(["tidy-checks", "database", "extra-arg", "ignore-tidy"])
+                .multiple(true)
+                .required(false),
+            ArgGroup::new("Clang-format options")
+                .args(["style", "ignore-format"])
+                .multiple(true)
+                .required(false),
+            ArgGroup::new("General options")
+                .args(["verbosity", "version"])
+                .multiple(true)
+                .required(false),
+            ArgGroup::new("Source options")
+                .args(["extensions", "repo-root", "ignore", "lines-changed-only", "files-changed-only"])
+                .multiple(true)
+                .required(false),
+            ArgGroup::new("Feedback options")
+                .args([
+                    "thread-comments",
+                    "no-lgtm",
+                    "step-summary",
+                    "file-annotations",
+                    "tidy-review",
+                    "format-review",
+                    "passive-reviews",
+                ])
+                .multiple(true)
+                .required(false),
         ])
         .next_line_help(true)
 }

cpp-linter/src/rest_api/github/serde_structs.rs

@@ -4,6 +4,7 @@
 use serde::{Deserialize, Serialize};
 
 use crate::clang_tools::Suggestion;
+use crate::rest_api::COMMENT_MARKER;
 
 #[derive(Debug, Serialize)]
 pub struct FullReview {
@@ -24,7 +25,7 @@ pub struct ReviewDiffComment {
 impl From<Suggestion> for ReviewDiffComment {
     fn from(value: Suggestion) -> Self {
         Self {
-            body: value.suggestion,
+            body: format!("{COMMENT_MARKER}{}", value.suggestion),
             line: value.line_end as i64,
             start_line: if value.line_end != value.line_start {
                 Some(value.line_start as i64)