make main return unit, not u8

Author: 2bndy5

cpp-linter/src/main.rs

@@ -1,14 +1,12 @@
 #![cfg(not(test))]
 /// This crate is the binary executable's entrypoint.
-use std::{env, process::ExitCode};
+use std::env;
 
 use ::cpp_linter::run::run_main;
 use anyhow::Result;
 
 /// This function simply forwards CLI args to [`run_main()`].
 #[tokio::main]
-pub async fn main() -> Result<ExitCode> {
-    Ok(ExitCode::from(
-        run_main(env::args().collect::<Vec<String>>()).await?,
-    ))
+pub async fn main() -> Result<()> {
+    run_main(env::args().collect::<Vec<String>>()).await
 }

cpp-linter/src/run.rs

@@ -8,7 +8,7 @@ use std::path::Path;
 use std::sync::{Arc, Mutex};
 
 // non-std crates
-use anyhow::Result;
+use anyhow::{anyhow, Result};
 use log::{set_max_level, LevelFilter};
 #[cfg(feature = "openssl-vendored")]
 use openssl_probe;
@@ -41,7 +41,7 @@ fn probe_ssl_certs() {
 /// is used instead of python's `sys.argv`, then the list of strings includes the entry point
 /// alias ("path/to/cpp-linter.exe"). Thus, the parser in [`crate::cli`] will halt on an error
 /// because it is not configured to handle positional arguments.
-pub async fn run_main(args: Vec<String>) -> Result<u8> {
+pub async fn run_main(args: Vec<String>) -> Result<()> {
     probe_ssl_certs();
 
     let arg_parser = get_arg_parser();
@@ -50,15 +50,15 @@ pub async fn run_main(args: Vec<String>) -> Result<u8> {
 
     if args.subcommand_matches("version").is_some() {
         println!("cpp-linter v{}", VERSION);
-        return Ok(0);
+        return Ok(());
     }
 
     logger::init().unwrap();
 
     if cli.version == "NO-VERSION" {
         log::error!("The `--version` arg is used to specify which version of clang to use.");
         log::error!("To get the cpp-linter version, use `cpp-linter version` sub-command.");
-        return Ok(1);
+        return Err(anyhow!("Clang version not specified."));
     }
 
     if cli.repo_root != "." {
@@ -135,9 +135,13 @@ pub async fn run_main(args: Vec<String>) -> Result<u8> {
         .await?;
     end_log_group();
     if env::var("PRE_COMMIT").is_ok_and(|v| v == "1") {
-        return Ok((checks_failed > 1) as u8);
+        if checks_failed > 1 {
+            return Err(anyhow!("Some checks did not pass"));
+        } else {
+            return Ok(());
+        }
     }
-    Ok(0)
+    Ok(())
 }
 
 #[cfg(test)]
@@ -157,14 +161,14 @@ mod test {
             "demo/demo.cpp".to_string(),
         ])
         .await;
-        assert!(result.is_ok_and(|v| v == 0));
+        assert!(result.is_ok());
     }
 
     #[tokio::test]
     async fn version_command() {
         env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
         let result = run_main(vec!["cpp-linter".to_string(), "version".to_string()]).await;
-        assert!(result.is_ok_and(|v| v == 0));
+        assert!(result.is_ok());
     }
 
     #[tokio::test]
@@ -178,7 +182,7 @@ mod test {
             "debug".to_string(),
         ])
         .await;
-        assert!(result.is_ok_and(|v| v == 0));
+        assert!(result.is_ok());
     }
 
     #[tokio::test]
@@ -191,7 +195,7 @@ mod test {
             "-V".to_string(),
         ])
         .await;
-        assert!(result.is_ok_and(|v| v == 1));
+        assert!(result.is_err());
     }
 
     #[tokio::test]
@@ -204,6 +208,6 @@ mod test {
             "false".to_string(),
         ])
         .await;
-        assert!(result.is_ok_and(|v| v == 1));
+        assert!(result.is_err());
     }
 }

cpp-linter/tests/comments.rs

@@ -242,7 +242,7 @@ async fn setup(lib_root: &Path, test_params: &TestParams) {
         args.push("-e=c".to_string());
     }
     let result = run_main(args).await;
-    assert!(result.is_ok_and(|v| v == 0));
+    assert!(result.is_ok());
     for mock in mocks {
         mock.assert();
     }

cpp-linter/tests/reviews.rs

@@ -222,7 +222,7 @@ async fn setup(lib_root: &Path, test_params: &TestParams) {
         args.push("-e=c".to_string());
     }
     let result = run_main(args).await;
-    assert!(result.is_ok_and(|v| v == 0));
+    assert!(result.is_ok());
     for mock in mocks {
         mock.assert();
     }

node-binding/src/lib.rs

@@ -4,7 +4,7 @@ use ::cpp_linter::run::run_main;
 use napi::bindgen_prelude::*;
 
 #[napi]
-pub async fn main(args: Vec<String>) -> Result<u8> {
+pub async fn main(args: Vec<String>) -> Result<()> {
     run_main(args)
         .await
         .map_err(|e| Error::new(Status::GenericFailure, e.to_string()))

py-binding/src/lib.rs

@@ -5,7 +5,7 @@ use ::cpp_linter::run::run_main;
 
 /// A wrapper for the ``::cpp_linter::run::run_main()```
 #[pyfunction]
-fn main(args: Vec<String>) -> PyResult<u8> {
+fn main(args: Vec<String>) -> PyResult<()> {
     Builder::new_multi_thread()
         .enable_all()
         .build()