fix fallback to home for cache dir

crazy-max · crazy-max · commit 18762a804768 · 2025-04-18T10:04:06.000+02:00
diff --git a/pkg/extractor/image/image.go b/pkg/extractor/image/image.go
@@ -65,9 +65,9 @@ func New(ctx context.Context, opts Options) (*extractor.Client, error) {
 	if len(datadir) == 0 {
 		datadir = os.Getenv("XDG_DATA_HOME")
 		if len(datadir) == 0 {
-			home := os.Getenv("HOME")
-			if len(home) == 0 {
-				return nil, errors.New("neither XDG_DATA_HOME nor HOME was set non-empty")
+			home, err := os.UserHomeDir()
+			if err != nil {
+				return nil, errors.Wrap(err, "failed to get home directory")
 			}
 			datadir = filepath.Join(home, ".local", "share")
 		}

Original file line number	Diff line number	Diff line change
`@@ -65,9 +65,9 @@ func New(ctx context.Context, opts Options) (*extractor.Client, error) {`
`65`	`65`	`if len(datadir) == 0 {`
`66`	`66`	`datadir = os.Getenv("XDG_DATA_HOME")`
`67`	`67`	`if len(datadir) == 0 {`
`68`		`- home := os.Getenv("HOME")`
`69`		`- if len(home) == 0 {`
`70`		`- return nil, errors.New("neither XDG_DATA_HOME nor HOME was set non-empty")`
	`68`	`+ home, err := os.UserHomeDir()`
	`69`	`+ if err != nil {`
	`70`	`+ return nil, errors.Wrap(err, "failed to get home directory")`
`71`	`71`	`}`
`72`	`72`	`datadir = filepath.Join(home, ".local", "share")`
`73`	`73`	`}`