Merge pull request #32 from ordago/no-and-or

refactors to use '||' and '&&' instead of 'and' and 'or' operators

Author: dtorras

src/RedsysFakeGateway.php

@@ -86,7 +86,7 @@ private function getResponseParameters(RequestParameters $inputParameters)
 
         if (
             $inputParameters->cofIni === CofInitial::No
-            and $inputParameters->merchantIdentifier
+            && $inputParameters->merchantIdentifier
         ) {
             $returnParameters['Ds_Card_Number'] = '454881******0003';
             $returnParameters['Ds_Merchant_Cof_Txnid'] = '2006031152000';

src/RedsysResponse.php

@@ -33,8 +33,8 @@ public function setParametersFromResponse(array $data): void
 
         if (
             empty($data['Ds_SignatureVersion'])
-            or empty($data['Ds_MerchantParameters'])
-            or empty($data['Ds_Signature'])
+            || empty($data['Ds_MerchantParameters'])
+            || empty($data['Ds_Signature'])
         ) {
             throw new InvalidRedsysResponseException('Redsys: invalid response from bank.');
         }
@@ -78,6 +78,6 @@ public function checkResponse(): NotificationParameters
 
     public static function isAuthorisedCode(int $responseCode): bool
     {
-        return ! ($responseCode > 99 and $responseCode !== 400 && $responseCode !== 900);
+        return ! ($responseCode > 99 && $responseCode !== 400 && $responseCode !== 900);
     }
 }