Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some questions about the Rand error computation #2

Open
thouis opened this issue Aug 16, 2016 · 2 comments
Open

some questions about the Rand error computation #2

thouis opened this issue Aug 16, 2016 · 2 comments

Comments

@thouis
Copy link

thouis commented Aug 16, 2016

I'm having trouble squaring the comments in the code and the code itself.

In this line, it says that background (zero) pixels are excluded from the computation:
https://github.com/cremi/cremi_python/blob/master/cremi/evaluation/rand.py#L13

In this line, the total number of pixels (zero and nonzero) are computed as "n":
https://github.com/cremi/cremi_python/blob/master/cremi/evaluation/rand.py#L42

And "n" is used here in the computation:
https://github.com/cremi/cremi_python/blob/master/cremi/evaluation/rand.py#L60-L61

I would expect n to be something like "np.count_nonzero(segA)"

@funkey
Copy link

funkey commented Aug 17, 2016

You are right, n should only reflect the number of valid locations. However, none of the reference implementations of the Adapted Rand Error (see also here) is doing so.

@thouis
Copy link
Author

thouis commented Aug 17, 2016

I think this can just be closed. If the bug in #3 is fixed, then it doesn't matter how n is computed, as it falls out of the equation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants