Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger.warn is removed in Python 3.13 #1098

Open
potens1 opened this issue Jan 3, 2019 · 5 comments · May be fixed by #1648
Open

logger.warn is removed in Python 3.13 #1098

potens1 opened this issue Jan 3, 2019 · 5 comments · May be fixed by #1648
Labels
bug CI-CD Python 3

Comments

@potens1
Copy link
Contributor

potens1 commented Jan 3, 2019 •
edited by oberstet
Loading

I know the warning comes from txaio, but, in fact, this is autobahn-python that uses the old deprecated log calls.

(Will try to do some PR later)

edit: changing warn by warning breaks all twisted tests, Logger has no attribute warning ...

ORIG TITLE: "txaio/aio.py:202: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead"
@potens1
Copy link
Contributor Author

potens1 commented Jan 3, 2019

I guess you are not very interested in a PR with only the asyncio specific code doing warning and other left as-this ?
If you are, I can do it, but, it's opening the door to have soon or later two autobahn version (twisted and asyncio, without txaio)

@oberstet
Copy link
Contributor

oberstet commented Jan 7, 2019

no, we won't merge anything that is only working on asyncio

@oberstet oberstet closed this as completed Jan 7, 2019
@meejah
Copy link
Contributor

meejah commented Jan 7, 2019

That said, we should still probably leave a bug open for this? (I would assume this means warn will at some point be removed)

@oberstet oberstet reopened this Jan 8, 2019
@oberstet
Copy link
Contributor

oberstet commented Jan 8, 2019

good point, might happen. reopened

@Jenselme
Copy link
Contributor

FYI, logger.warn is removed in Python 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#logging

@oberstet oberstet changed the title txaio/aio.py:202: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead logger.warn is removed in Python 3.13 Jun 17, 2024
Jenselme added a commit to Jenselme/autobahn-python that referenced this issue Aug 22, 2024
@Jenselme
Switch to log.warning instead of log.warn
e37d449 
log.warn is removed in Python 3.13

Close crossbario#1098
@Jenselme Jenselme linked a pull request Aug 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug CI-CD Python 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to log.warning instead of log.warn Jenselme/autobahn-python
4 participants
@meejah @oberstet @potens1 @Jenselme