Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automated Tests For Crossbar Routers Connected With RLink #2083

Open
Skully17 opened this issue Jun 12, 2023 · 0 comments
Open

Add Automated Tests For Crossbar Routers Connected With RLink #2083

Skully17 opened this issue Jun 12, 2023 · 0 comments

Comments

@Skully17
Copy link
Contributor

In response to the comment made here: #2079 (comment), I have written some automated that tests any scenarios that came to mind and, most importantly, re-creates the errors that I fixed in this PR: #2080.

The code can be found here: https://github.com/Skully17/playground/blob/master/crossbar_tests/test_rlink.py
Please let me know if there is another way you would like me to share the code.

I have not made a PR for two reasons:

  1. I don't know where it would be suitable to put these tests in the Crossbar project
  2. I assume that there are some changes that will need to be made before it is satisfactory

During the making of these tests I found another issue that I fixed and a potential issue that needs more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant