remove todos

Author: mobula9

docs/api/RestClient.md

@@ -90,9 +90,7 @@ Send an HTTP request using the file_get_contents and parse its JSON result if an
 
 
 `\BouncerException`
-> when the reponse status is not 2xx.  
-  
-TODO P3 test the request method
+> when the reponse status is not 2xx.
 
 <hr />
 

docs/contribute.md

@@ -86,6 +86,7 @@ After the merge, don't forget to delete to branch.
 #### New release
 
 ```bash
+git checkout main && git pull
 git describe --tags # to verify what is the current tag
 gh release create --draft vx.x.x --title vx.x.x
 ```

src/ApiCache.php

@@ -281,9 +281,7 @@ private function saveRemediationsForIp(array $decisions, string $ip): string
             foreach ($decisions as $decision) {
                 if (!\in_array($decision['type'], Constants::ORDERED_REMEDIATIONS)) {
                     $highestRemediationLevel = Constants::ORDERED_REMEDIATIONS[0];
-                    // TODO P1 test the case of unknown remediation type
                     $this->logger->warning('', ['type' => 'UNKNOWN_REMEDIATION', 'remediation' => $decision['type']]);
-                    // TODO P2 use the fallback parameter instead.
                     $decision['type'] = $highestRemediationLevel;
                 }
                 $remediation = $this->formatRemediationFromDecision($decision);

src/RestClient.php

@@ -68,8 +68,6 @@ private function convertHeadersToString(array $headers): string
      * Send an HTTP request using the file_get_contents and parse its JSON result if any.
      *
      * @throws BouncerException when the reponse status is not 2xx.
-     *
-     * TODO P3 test the request method
      */
     public function request(
         string $endpoint,

tests/LoadPaginatedDecisionsTest.php

@@ -3,11 +3,6 @@
 declare(strict_types=1);
 use PHPUnit\Framework\TestCase;
 
-/*
-TODO P3 Implement decisions pagination tests
-cf https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice
-*/
-
 final class LoadPaginatedDecisionsTest extends TestCase
 {
     /**

tests/LoadPaginatedLogsTest.php

@@ -3,10 +3,6 @@
 declare(strict_types=1);
 use PHPUnit\Framework\TestCase;
 
-/*
-TODO P3 Implement decisions pagination tests
-*/
-
 final class LoadPaginatedLogsTest extends TestCase
 {
     /**

tests/Template403Test.php

@@ -38,10 +38,6 @@ public static function createLogger(): Logger
     public static function cacheAdapterProvider(): array
     {
         // Init all adapters
-        /*
-        TODO P3 Failed on CI but some fixes may fix this bug. Just retry it could work! Else investigates.
-        $fileSystemAdapter = new FilesystemAdapter('fs_adapter_cache', 0, self::FS_CACHE_ADAPTER_DIR);
-        */
 
         $phpFilesAdapter = new PhpFilesAdapter('php_array_adapter_backup_cache', 0, self::PHP_FILES_CACHE_ADAPTER_DIR);