From 949ce2ac8697fb13b9e6d6602e01e5907a12bab8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20M=C3=BCller?= Date: Fri, 20 Sep 2024 11:21:01 +0200 Subject: [PATCH 1/2] Fix compiler artifact name in WindowsCI Before https://github.com/crystal-lang/crystal/pull/15000 we had two different builds of the compiler in every CI run, a release build and a non-release. Now we only have a release build and there's no need to differentiate by name. Going back to `crystal` makes the install-crystal action work again. --- .github/workflows/win_build_portable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/win_build_portable.yml b/.github/workflows/win_build_portable.yml index 98c428ee5bad..272226d1e6e8 100644 --- a/.github/workflows/win_build_portable.yml +++ b/.github/workflows/win_build_portable.yml @@ -145,5 +145,5 @@ jobs: - name: Upload Crystal binaries uses: actions/upload-artifact@v4 with: - name: ${{ inputs.release && 'crystal-release' || 'crystal' }} + name: crystal path: crystal From 4ab6dbf9c1929f6011881dd9cdb2709bf6767976 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20M=C3=BCller?= Date: Fri, 20 Sep 2024 14:11:12 +0200 Subject: [PATCH 2/2] fixup --- .github/workflows/win.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/win.yml b/.github/workflows/win.yml index 89c13959e8cb..9025586fa991 100644 --- a/.github/workflows/win.yml +++ b/.github/workflows/win.yml @@ -252,7 +252,7 @@ jobs: - name: Download Crystal executable uses: actions/download-artifact@v4 with: - name: crystal-release + name: crystal path: build - name: Restore LLVM @@ -294,7 +294,7 @@ jobs: - name: Download Crystal executable uses: actions/download-artifact@v4 with: - name: crystal-release + name: crystal path: build - name: Restore LLVM @@ -330,7 +330,7 @@ jobs: - name: Download Crystal executable uses: actions/download-artifact@v4 with: - name: crystal-release + name: crystal path: etc/win-ci/portable - name: Restore LLVM