Skip to content

GWindow can't currently be freed #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmalan opened this issue Jan 25, 2017 · 0 comments
Open

GWindow can't currently be freed #14

dmalan opened this issue Jan 25, 2017 · 0 comments
Assignees

Comments

@dmalan
Copy link
Member

dmalan commented Jan 25, 2017

It seems a GWindow can't currently be freed:

There does seem to be a generic remove function, defined in StanfordCSLib/src/generic.c, right after the generic add function. However, it looks to me like the handling of GWindow by remove is buggy. The relevant branch of remove reads:

   if (endsWith(type, "GWindow")) {
      va_start(args, arg);
      gobj = va_arg(args, GObject);
      va_end(args);
      removeGWindow((GWindow) arg, key);
   }

At this point in the code, key is uninitialized. I believe the intent was to pass gobj to removeGWindow, not key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants