Merge pull request scala#7301 from som-snytt/issue/deflag

Partest warns about orphan flags or check

Author: adriaanm

src/partest/scala/tools/partest/TestKinds.scala

@@ -35,8 +35,15 @@ class TestKinds(pathSettings: PathSettings) {
     (candidates exists matches)
   }
 
-  def testsFor(kind: String): List[Path] = (pathSettings.srcDir / kind toDirectory).list.toList filter denotesTestPath
+  def testsFor(kind: String): (List[Path], List[Path]) = {
+    val (ti, others) = (pathSettings.srcDir / kind).toDirectory.list.partition(denotesTestPath)
+    val ts = ti.toList
+    val names = ts.toSet
+    def warnable(p: Path) = (p.hasExtension("flags") || p.hasExtension("check")) &&
+      !names(p.changeExtension("scala")) && !names(p.parent / p.stripExtension)
+    (ts, others.filter(warnable).toList)
+  }
   def grepFor(expr: String): List[Path]  = standardTests filter (t => pathMatchesExpr(t, expr))
-  def standardTests: List[Path]          = standardKinds flatMap testsFor
+  def standardTests: List[Path]          = standardKinds flatMap (k => testsFor(k)._1)
   def failedTests: List[Path]            = standardTests filter (p => logOf(p).isFile)
 }

src/partest/scala/tools/partest/nest/AbstractRunner.scala

@@ -214,7 +214,11 @@ class AbstractRunner(val config: RunnerSpec.Config, protected final val testSour
         else if (miscTests.isEmpty && invalid.isEmpty) standardKinds // If no kinds, --grep, or individual tests were given, assume --all, unless there were invalid files specified
         else Nil
       )
-      val kindsTests = kinds flatMap testsFor
+      val kindsTests = kinds.flatMap { k =>
+        val (good, bad) = testsFor(k)
+        bad.foreach(baddie => echoWarning(s"Extraneous file: $baddie"))
+        good
+      }
 
       def testContributors = {
         List(