Fix/debit edit and sepa (#421)

* fixes a console log error
console error existed due to the value of const thread being undefined. This mark as read request should only be sent when having visited a thread.

* fixes a debug log mistake
prior to this change, the app would keep logging that users lack permissions during hasPermission calls, no matter if the user actually lacked the permissions

* fixes model related issues:
improper linkargument for debit.collection.sepa route
record name in model hook for debit.collection.edit route

* lint fix

Author: DrumsnChocolate

app/routes/debit/collections/edit.js

@@ -8,7 +8,7 @@ export default class EditCollectionRoute extends AuthenticatedRoute {
   }
 
   model(params) {
-    return this.store.findRecord('debit/collections', params.id, params);
+    return this.store.findRecord('debit/collection', params.id, params);
   }
 
   deactivate() {

app/routes/debit/collections/show.js

@@ -28,7 +28,7 @@ export default class CollectionsIndexRoute extends AuthenticatedRoute {
         link: 'debit.collections.sepa',
         title: 'SEPA bestand downloaden',
         icon: 'download',
-        linkArgument: collection,
+        linkArgument: collection.id,
         canAccess: this.abilities.can('download sepa debit/collections')
       }
     ];

app/routes/forum/categories/category/threads/thread/posts/index.js

@@ -54,7 +54,9 @@ export default class PostIndexRoute extends AuthenticatedRoute {
 
     this.router.on('routeDidChange', () => {
       const thread = this.modelFor('forum.categories.category.threads.thread');
-      this.fetch.fetch(`/forum/threads/${thread.id}/mark_read`, { method: 'POST' });
+      if (thread) {  // only mark as read if we are in a thread
+        this.fetch.fetch(`/forum/threads/${thread.id}/mark_read`, { method: 'POST' });
+      }
     });
   }
 }

app/services/session.js

@@ -35,18 +35,20 @@ export default class SessionService extends BaseSessionService {
       let user = await this.store.query('user', { me: true, include: 'user_permissions' });
       await user.firstObject.permissions; // Load the permissions
       this.currentUser = user.firstObject;
-
       Sentry.setUser({ id: this.currentUser?.id });
     }
   }
 
   hasPermission(permissionName) {
     const hasPermission = !isNone(this.currentUser) && this.currentUser.hasPermission(permissionName);
-    debug(
-      `Current user does not have permission '${permissionName}'`,
-      !ENV.APP.LOG_ACCESS_CONTROL || hasPermission,
-      { id: 'alpha-amber.session.no-permission' }
-    );
+    if (!hasPermission) {
+      debug(
+        `Current user does not have permission '${permissionName}'`,
+        !ENV.APP.LOG_ACCESS_CONTROL || hasPermission,
+        { id: 'alpha-amber.session.no-permission' }
+      );
+    }
+
     return hasPermission;
   }
 }