Skip to content

Commit 038b124

Browse files
committed
OMG! Is it really working?!
1 parent f1554b7 commit 038b124

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,11 +518,15 @@ export class BaseQuery {
518518
// Safeguard against infinite loop in case of cyclic joins somehow managed to slip through
519519
let cnt = 0;
520520

521-
while (newJoin?.joins.length > 0 && !isJoinTreesEqual(prevJoin, newJoin) && cnt < 10000) {
521+
while (newJoin?.joins.length > 0 && cnt < 10000) {
522522
prevJoin = newJoin;
523523
joinMembersJoinHints = this.collectJoinHintsFromMembers(this.joinMembersFromJoin(newJoin));
524524
newJoin = this.joinGraph.buildJoin(constructJH());
525525

526+
if (isJoinTreesEqual(prevJoin, newJoin)) {
527+
break;
528+
}
529+
526530
const [isOrdered, msg] = isOrderPreserved([allMembersHintsFlattened[0], ...joinMembersJoinHints]);
527531

528532
if (!isOrdered) {

0 commit comments

Comments
 (0)