From a1e7aacf540dac5a8d05d9c7bcde1ddc0d6aca79 Mon Sep 17 00:00:00 2001 From: Luke Hill Date: Mon, 16 Sep 2024 17:19:35 +0100 Subject: [PATCH 1/7] Update all dev dependencies --- ruby/cucumber-messages.gemspec | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ruby/cucumber-messages.gemspec b/ruby/cucumber-messages.gemspec index 98de5c20..f6c1ebc8 100644 --- a/ruby/cucumber-messages.gemspec +++ b/ruby/cucumber-messages.gemspec @@ -23,13 +23,13 @@ Gem::Specification.new do |s| 'source_code_uri' => 'https://github.com/cucumber/messages' } - s.add_development_dependency 'cucumber-compatibility-kit', '~> 15.0' - s.add_development_dependency 'rake', '~> 13.1' + s.add_development_dependency 'cucumber-compatibility-kit', '~> 16.2' + s.add_development_dependency 'rake', '~> 13.2' s.add_development_dependency 'rspec', '~> 3.13' - s.add_development_dependency 'rubocop', '~> 1.50.2' - s.add_development_dependency 'rubocop-performance', '~> 1.21.0' + s.add_development_dependency 'rubocop', '~> 1.66.1' + s.add_development_dependency 'rubocop-performance', '~> 1.22.0' s.add_development_dependency 'rubocop-rake', '~> 0.6.0' - s.add_development_dependency 'rubocop-rspec', '~> 2.25.0' + s.add_development_dependency 'rubocop-rspec', '~> 3.0.5' s.files = Dir['README.md', 'LICENSE', 'VERSION', 'lib/**/*'] s.rdoc_options = ['--charset=UTF-8'] From 750738c9eff89a887eda78cd3e9b0525cf09b31a Mon Sep 17 00:00:00 2001 From: Luke Hill Date: Mon, 16 Sep 2024 17:20:23 +0100 Subject: [PATCH 2/7] Omit dev dependencies cop --- ruby/.rubocop.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ruby/.rubocop.yml b/ruby/.rubocop.yml index fdd1dfe8..d34d4247 100644 --- a/ruby/.rubocop.yml +++ b/ruby/.rubocop.yml @@ -12,6 +12,9 @@ AllCops: TargetRubyVersion: 3.0 NewCops: enable +Gemspec/DevelopmentDependencies: + Enabled: false + Gemspec/RequireMFA: Enabled: false From fec2e3fd22561acc4deafa346f6352b9309fb28e Mon Sep 17 00:00:00 2001 From: Luke Hill Date: Mon, 16 Sep 2024 17:26:34 +0100 Subject: [PATCH 3/7] Add attribution for maintenance --- ruby/cucumber-messages.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ruby/cucumber-messages.gemspec b/ruby/cucumber-messages.gemspec index f6c1ebc8..a9357b1b 100644 --- a/ruby/cucumber-messages.gemspec +++ b/ruby/cucumber-messages.gemspec @@ -5,7 +5,7 @@ version = File.read(File.expand_path('VERSION', __dir__)).strip Gem::Specification.new do |s| s.name = 'cucumber-messages' s.version = version - s.authors = ['Aslak Hellesøy'] + s.authors = ['Aslak Hellesøy', 'Luke Hill'] s.description = "JSON schema-based messages for Cucumber's inter-process communication" s.summary = "cucumber-messages-#{s.version}" s.email = 'cukes@googlegroups.com' From 7ad94991afa75ea7ab7364d0741a310336cd896b Mon Sep 17 00:00:00 2001 From: Luke Hill Date: Mon, 16 Sep 2024 17:26:46 +0100 Subject: [PATCH 4/7] Add rubocop to workflow and update changelog --- .github/workflows/test-ruby.yml | 10 ++++++++++ CHANGELOG.md | 2 ++ 2 files changed, 12 insertions(+) diff --git a/.github/workflows/test-ruby.yml b/.github/workflows/test-ruby.yml index 299ce387..23ba9ded 100644 --- a/.github/workflows/test-ruby.yml +++ b/.github/workflows/test-ruby.yml @@ -11,6 +11,16 @@ on: workflow_call: jobs: + rubocop: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: ruby/setup-ruby@v1 + with: + ruby-version: '3.0' + bundler-cache: true + - run: bundle exec rubocop + test-ruby: runs-on: ${{ matrix.os }} strategy: diff --git a/CHANGELOG.md b/CHANGELOG.md index 37ab414a..c517611b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,8 +8,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] ### Fixed - [Dotnet] Fixed code generation for types that accept List as parameters. Constructors were not properly handling null input. ([#249](https://github.com/cucumber/messages/pull/249) [clrudolphi]) + ### Changed - [Go] Switch to Google's UUID module ([#251](https://github.com/cucumber/messages/pull/251)) +- [Ruby] Updated the rubocop dependencies to use latest cops & run rubocop in pipeline ## [26.0.0] - 2024-08-15 ### Added From ccfe0ba3767d1d79136b111e3cdb6c04a41a0989 Mon Sep 17 00:00:00 2001 From: Luke Hill Date: Mon, 16 Sep 2024 17:29:47 +0100 Subject: [PATCH 5/7] Fix changelog attribution --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c517611b..7b87a3da 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] ### Fixed -- [Dotnet] Fixed code generation for types that accept List as parameters. Constructors were not properly handling null input. ([#249](https://github.com/cucumber/messages/pull/249) [clrudolphi]) +- [Dotnet] Fixed code generation for types that accept List as parameters. Constructors were not properly handling null input. ([#249](https://github.com/cucumber/messages/pull/249) [clrudolphi](https://github.com/clrudolphi)) ### Changed - [Go] Switch to Google's UUID module ([#251](https://github.com/cucumber/messages/pull/251)) From 1eefb4aebf59f6db00b6deeb665e09760a68df60 Mon Sep 17 00:00:00 2001 From: Luke Hill Date: Mon, 23 Sep 2024 09:23:59 +0100 Subject: [PATCH 6/7] Fix reference to cck --- ruby/spec/cucumber/messages/acceptance_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ruby/spec/cucumber/messages/acceptance_spec.rb b/ruby/spec/cucumber/messages/acceptance_spec.rb index f0dc0631..afe4cd42 100644 --- a/ruby/spec/cucumber/messages/acceptance_spec.rb +++ b/ruby/spec/cucumber/messages/acceptance_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'json' -require 'cucumber-compatibility-kit' +require 'cck/examples' module Cucumber module Messages From fc3e81304c39792c59470424a11a8c1a377b45dc Mon Sep 17 00:00:00 2001 From: Luke Hill Date: Mon, 23 Sep 2024 09:25:57 +0100 Subject: [PATCH 7/7] Fix up linting for yaml --- .github/workflows/test-ruby.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test-ruby.yml b/.github/workflows/test-ruby.yml index 23ba9ded..d987ffce 100644 --- a/.github/workflows/test-ruby.yml +++ b/.github/workflows/test-ruby.yml @@ -32,7 +32,6 @@ jobs: include: - os: macos-latest ruby: '3.3' - steps: - uses: actions/checkout@v4 - uses: ruby/setup-ruby@v1