-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cuppa should merge test blocks with the same path #61
Comments
How will this work with hooks? It isn't clear to me. |
Perhaps this is just a concern for reporting. I'm still not quite sure we should do this. One problem it introduces is that it breaks the 1-to-1 relationship between a test/testblock and the code that defined it. How would an editor jump to the right place in code? |
I'd expect an error for this to be honest
|
I can think of plausible use cases where the user may want blocks with the same name. For example, the user has some high-level components and wants all tests relating to each component under a top-level At this point I don't know enough to say whether that is good or bad practice, so I'd prefer not to rule it out. |
Expected:
Reports a single
a
when block with two tests,test1
andtest2
, nested under it.Actual:
Reports two
a
when blocks with one test nested under each.The text was updated successfully, but these errors were encountered: