Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring-Cleaning for 2025 #132

Open
cmeister2 opened this issue Mar 7, 2025 · 5 comments
Open

Spring-Cleaning for 2025 #132

cmeister2 opened this issue Mar 7, 2025 · 5 comments
Assignees

Comments

@cmeister2
Copy link
Collaborator

cmeister2 commented Mar 7, 2025

It'd be nice if the code was a little more up to date. Here's a (non-exhaustive) list of things I'd like to cover in the short term.

Poetry (done)

Make the project a poetry project for the Python files so that Renovate works and there's a standard interface for scripts, etc, as well as an easy method for setting up virtual environments.

Reduce the number of bash scripts

Surely there's a better technology that we can use for this! Investigate what that might be.

Make TLVs better / easier to populate from the curl code

We've languished without a load of new options for ages because adding TLVs is a chore. I'd hope that it's relatively easy in the curl code to differentiate between what options take what type of value (i.e. string argument, number, etc), and have a script add those in automatically.

Better format for testcases

The TLV format is fine but it might be suboptimal for fuzzing. Look into structured fuzzing.

@cmeister2 cmeister2 self-assigned this Mar 7, 2025
@bagder
Copy link
Member

bagder commented Mar 7, 2025

I'd hope that it's relatively easy in the curl code to differentiate between what options take what type of value (i.e. string argument, number, etc), and have a script add those in automatically.

I'd say it is relatively easy. The easyoptions.c file is generated to hold that information.

@dfandrich
Copy link

dfandrich commented Mar 7, 2025 via email

@cmeister2
Copy link
Collaborator Author

W.r.t. poetry, that seems like overkill for so little Python, especially since
there seems to be a total of one additional dependency. Adding Poetry would
double that! A pyproject.toml would still be useful to document that dependency.

Fair, but it would allow me to specify dev-dependencies as well. Since I'm probably 1 of maybe 3 people who ever use the Python in this repo, I don't feel like it's a stretch to add this.

@dfandrich
Copy link

dfandrich commented Mar 8, 2025 via email

@cmeister2
Copy link
Collaborator Author

re: reducing scripts; it seems like the contenders for this are:

  • do it in CMake
  • do it in Meson

I know neither of these so I have no preconceptions about either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants