Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings to NOTES.txt #135

Open
diverdane opened this issue Jan 20, 2021 · 0 comments
Open

Add deprecation warnings to NOTES.txt #135

diverdane opened this issue Jan 20, 2021 · 0 comments

Comments

@diverdane
Copy link
Contributor

Is your feature request related to a problem? Please describe.

There are some features that have been documented as being deprecated.
However, there are no warnings issued after a Helm chart has been installed/upgraded
(as part of the conjur-oss/templates/NOTES.txt).

The conjur-oss/templates/NOTES.txt should be updated to provide deprecation
warnings for the following:

  • Automatic Conjur account creation will become the default in next major release.
  • A ClusterRoleBinding will not be created by default in next major release.

It may be possible to emit deprecation warnings ONLY when the deprecated
feature is actually in use, e.g.:

  • When account.create is set to false (either explicitly or by default)
  • When rbac.create is set to false

Describe the solution you would like

  • Deprecation warnings (see above) should appear after a chart has been installed/upgraded.
  • Ideally, the deprecation warnings should show up conditionally based on whether the
    deprecated feature is being used.

Describe alternatives you have considered

N/A

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant