Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart error handling #38

Open
1 of 14 tasks
sneurlax opened this issue Jan 23, 2024 · 0 comments
Open
1 of 14 tasks

Dart error handling #38

sneurlax opened this issue Jan 23, 2024 · 0 comments

Comments

@sneurlax
Copy link
Member

Following up on #37:

The following additional functions have poor error-handing and could benefit from similar changes as found in #37:

  • scanOutputs
  • cancelTransaction
  • recoverWallet
  • initializeNewWallet
  • createTransaction
  • getChainHeight
  • getAddressInfo
  • deleteWallet
  • openWallet
  • txHttpSend

Fair but could be good:

  • getTransactions
  • validateSendAddress

Good but could be better:

  • getWalletBalances
  • getMnemonic

Lots of catches could use additional error context: where we return the original/passed error, add extra contextual information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sneurlax