fix: fix error when testing cross-origin code (#685)

Author: Nojay-Games

.circleci/config.yml

@@ -40,11 +40,11 @@ jobs:
     steps:
       - checkout
       - run:
-          name: Install node 16
-          command: nvm install 16.16.0
+          name: Install node 20
+          command: nvm install 20.12.1
       - run:
-          name: Use node 16
-          command: nvm use 16.16.0
+          name: Use node 20
+          command: nvm use 20.12.1
       - run:
           name: Install deps for code coverage
           command: npm ci

package-lock.json

@@ -66,8 +66,13 @@ const registerHooks = () => {
     windowCoverageObjects = []
 
     const saveCoverageObject = (win) => {
-      // if application code has been instrumented, the app iframe "window" has an object
-      const applicationSourceCoverage = win?.__coverage__
+      // if the application code has been instrumented, then the app iframe "win.__coverage__" will be available,
+      // in addition, accessing win.__coverage__ can throw when testing cross-origin code,
+      // because we don't control the cross-origin code, we can safely return
+      let applicationSourceCoverage
+      try {
+        applicationSourceCoverage = win?.__coverage__
+      } catch {}
       if (!applicationSourceCoverage) {
         return
       }

support.js

@@ -1,3 +1,4 @@
 {
-  "plugins": ["istanbul"]
+  "plugins": ["istanbul"],
+  "ignore": ["**/*.cy.js"]
 }

test-apps/frontend/.babelrc

@@ -6,6 +6,9 @@ module.exports = defineConfig({
     setupNodeEvents(on, config) {
       return require('./cypress/plugins/index.js')(on, config)
     },
+    hosts: {
+      'foobar.com': '127.0.0.1',
+    },
     baseUrl: 'http://localhost:1234',
     env: {
       codeCoverage: {

test-apps/frontend/cypress.config.js

@@ -25,6 +25,16 @@ context('Page test', () => {
     cy.contains('h2', 'About')
     cy.contains('Est. 2019')
   })
+
+  it('loads cross origin page using cy.origin', () => {
+    cy.origin('http://foobar.com:1234', () => {
+      cy.visit('/')
+    })
+  })
+
+  it('loads cross origin page without cy.origin', () => {
+    cy.visit('http://foobar.com:1234')
+  })
 })
 
 context('Unit tests', () => {