Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable Percy recording #1416

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore: re-enable Percy recording #1416

merged 1 commit into from
Oct 19, 2023

Conversation

astone123
Copy link
Contributor

Closes #1409

Somewhere along the way, we disabled Percy snapshots in our CI runs. This change enables Percy for our Chrome E2E tests, like we had it before. You can see that Percy recorded snapshots from our Chrome E2E tests in the CircleCI run on this branch https://app.circleci.com/pipelines/github/cypress-io/cypress-realworld-app/5578/workflows/a4637ab8-38f7-48f2-aba7-db8c4b25e4ad/jobs/35502?invite=true#step-104-10325_96

@astone123 astone123 self-assigned this Oct 18, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

@astone123
Copy link
Contributor Author

@MikeMcC399 FYI

@astone123 astone123 requested a review from mschile October 18, 2023 16:26
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bfecadd) 86.05% compared to head (7d27c97) 89.35%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1416      +/-   ##
===========================================
+ Coverage    86.05%   89.35%   +3.30%     
===========================================
  Files           95       95              
  Lines         1606     1606              
  Branches       256      256              
===========================================
+ Hits          1382     1435      +53     
+ Misses         224      171      -53     

see 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 18, 2023

Passing run #6166 ↗︎

0 448 2 0 Flakiness 0

Details:

chore: re-enable Percy
Project: cypress-realworld-app Commit: 7d27c97a0a
Status: Passed Duration: 29:54 💡
Started: Oct 18, 2023 4:17 PM Ended: Oct 18, 2023 4:47 PM

Review all test suite changes for PR #1416 ↗︎

@astone123 astone123 requested a review from mjhenkes October 18, 2023 20:35
@astone123 astone123 merged commit f7bb052 into develop Oct 19, 2023
29 checks passed
@astone123 astone123 deleted the astone123/enable-percy branch October 19, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Percy for visual testing is not reporting
4 participants