[FEATURE REQUEST]ESP32 support

[luc-github]

I know it may need some esp32 core update but any chance for ESP32 support ?

[d-a-v]

There are little updates done in esp8266 arduino core to enable web hooks.
Unfortunately the PR is mixed with other internal changes.
Functionality main changes are:

• WEBSERVER_HAS_HOOK
• definitions
• declaration
• addHook()
• hook call
• example

I guess the hook call in ESP 32 arduino would have to happen there.

Do you think you could make a PR of it ?

[luc-github]

So if I implement each steps - in theory it should be ok ?
I give a try and report to you ^_^ thank you

[d-a-v]

So if I implement each steps - in theory it should be ok ?

It will be OK, no reason against it.

I forgot to mention the return type in

bool WebServer::_parseRequest(WiFiClient& client)

that must be changed to ClientFuture.

• return false => return CLIENT_MUST_STOP
• return true => return CLIENT_REQUEST_CAN_CONTINUE
• update the caller of this function to manage the return value (4 choices).

[luc-github]

ok noted - thank you 👍

[luc-github]

@d-a-v I did first part luc-github/arduino-esp32@b523379
seems working - I have followed your instructions even I have no idea of what I am doing ^_^

Testing with HelloServer.ino

/ and I got hello from esp32! in browser=>ok
/dump and no answer in browser =>ok
/yes and got proper answer

File Not Found

URI: /yes
Method: GET
Arguments: 0

On serial

Connected to WIFI_OFFICE_A2G
IP address: 192.168.1.61
MDNS responder started
HTTP server started
A useless web hook has passed
A useless web hook has passed
The dumper web hook is on the run
(<32> chars)Host: 192.168.1.61
Connection: (<32> chars)keep-alive
Upgrade-Insecure-Req(<32> chars)uests: 1
User-Agent: Mozilla/5.(<32> chars)0 (Windows NT 10.0; Win64; x64) (<32> chars)AppleWebKit/537.36 (KHTML, like (<32> chars)Gecko) Chrome/87.0.4280.88 Safar(<32> chars)i/537.36
Accept: text/html,appl(<32> chars)ication/xhtml+xml,application/xm(<32> chars)l;q=0.9,image/avif,image/webp,im(<32> chars)age/apng,*/*;q=0.8,application/s(<32> chars)igned-exchange;v=b3;q=0.9
Accep(<32> chars)t-Encoding: gzip, deflate
Accep(<32> chars)t-Language: fr-FR,fr;q=0.9,en-US(<19> chars);q=0.8,en;q=0.7


Telling server to forget this connection

Now checking WebDav code but I have realized that FS of ESP32 is different from ESP8266 so cannot be drop as it is , as well as all call related to ESP8266WebServer - I will check that part first before pushing PR to ESP32 core

[d-a-v]

The "hooked" way of using espwebdav imposes that the files on the filesystem are stored in /theHookedDirectory/.
I understand that it is currently a limitation.
Until this is improved, can you try to store files in the FS's directory /yes/ and check if you can see them in a webdav browser ?

[luc-github]

Sorry you misunderstood my test
/ is to check root
/dump is the hook
/yes was to go to not found handler so it is working as expect

So it is ok with Helloserver.ino, I have clarified my report

[luc-github]

hi here the POC luc-github@d949d6f

I have some refresh problem - but not sure how to address it

[luc-github]

OK I have followed your advice and indeed debug was part of issue
the other part was the File system difference SPIFFS esp32 is different to SPIFFS

• the file/dir detection - I use exists instead of open
• the mkdir feature - it does not work

Helloserver.ino => Ok
Simple_esp32.ino =>Ok
Hooked_esp32.ino => WebDav Not working - under investigation

[d-a-v]

the mkdir feature - it does not work

spiffs has no support for directories, but sdfs has. What FS did you try with ?
Does esp32/arduino have littlefs (it has support for directories too).

[luc-github]

yes I know, I am trying with SPIFFS - ESP32 has SPIFFS/FAT /SD not yet LITTLEFS , it is planned in 2.0 but currently it can be used as external FS - I will try it later

I also suspect the pb with the hooked is also related with directory pb, a nice to have would be to separate the url from the real directory name
for example use http://192.168.1.61/dav but map the / of the FS or /www/dav of FS not /dav

[d-a-v]

The "hooked" way of using espwebdav imposes that the files on the filesystem are stored in /theHookedDirectory/.

for example use http://192.168.1.61/dav but map the / of the FS or /www/dav of FS not /dav

That is a fair request