Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: DagsterGraphQLClient.terminate_runs should support force option #28338

Open
hbruch opened this issue Mar 9, 2025 · 0 comments · May be fixed by #28339
Open

Feature Request: DagsterGraphQLClient.terminate_runs should support force option #28338

hbruch opened this issue Mar 9, 2025 · 0 comments · May be fixed by #28339
Labels
area: graphql Related to GraphQL API type: feature-request

Comments

@hbruch
Copy link

hbruch commented Mar 9, 2025

What's the use case?

Currently, DagsterGraphQLClient.terminate_runs and DagsterGraphQLClient.terminate_run only accept run_id/run_ids as parameter.

The terminatePolicy can't be specified and hence defaults to SAFE_TERMINATE.

Ideas of implementation

I suggest to add an addtional, optional param force: bool which, if true, will let the client execute with MARK_AS_CANCELED_IMMEDIATELY.

Additional information

(See also #28182 for context)

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
@hbruch hbruch linked a pull request Mar 9, 2025 that will close this issue
Open
@garethbrickman garethbrickman added the area: graphql Related to GraphQL API label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: graphql Related to GraphQL API type: feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dagster-client): support forced run termination mfdz/dagster
2 participants
@hbruch @garethbrickman