Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something about "magic numbers" in CSS examples #244

Open
bertfrees opened this issue Aug 13, 2024 · 1 comment
Open

Do something about "magic numbers" in CSS examples #244

bertfrees opened this issue Aug 13, 2024 · 1 comment
Assignees
Labels
Best practices - styling Issue for the best practices styling document Best practices - tagging Issue for the best practices tagging document Topic - css

Comments

@bertfrees
Copy link
Member

bertfrees commented Aug 13, 2024

See for example the Simple box with blank lines example:

.box {
   border-style: solid;
   border-width: .45rem 0;
   margin: 1.22rem 0 1.55rem 0;
   padding: .33rem 0 0 0;
}

Either these numbers need an explanation (how to obtain the numbers?), or we need to recommend another approach that doesn't need the numbers (e.g. we could further develop the "border image" approach).

@bertfrees bertfrees added Topic - css Best practices - tagging Issue for the best practices tagging document labels Aug 13, 2024
@bertfrees
Copy link
Member Author

See #261

@bertfrees bertfrees self-assigned this Sep 9, 2024
@mattgarrish mattgarrish added the Best practices - styling Issue for the best practices styling document label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Best practices - styling Issue for the best practices styling document Best practices - tagging Issue for the best practices tagging document Topic - css
Projects
None yet
Development

No branches or pull requests

2 participants