-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close tab action #113
Comments
I have purposely chosen "job" instead of "tab" because it seems a little more meaningful and also the idea of a tabbed interface was being questioned at earlier stages so I didn't want to tie everything to the word "tab". Although I know with tabbed interfaces it common to see "tab" spelled out. As the saying goes, though, I don't really have a strong opinion here. I think "cancel job" makes sense when the job has not been submitted. A quick check of firefox and chrome shows "Close Tab - cmd+W" and "Close Window - shift+cmd+W" are both always active even when there's just one tab. |
We should find out what the equivalent convention is on Windows too. |
On Windows, if I look at browsers like edge and firefox, tabs are closed when using Ctrl+w, and the window is closed with ctrl+shift+w. |
When there is a meaningful name for a tab like in this case, I think it indeed makes sense to use that. E.g. Acrobat Reader has "Close File". And indeed also good point about not tying everything to tabs.
It would be fine to have "Close Job"/"Close Tab" for all cases. But if the close action has a certain meaning depending on the state of the job, it also makes sense to make that explicit in the name I think.
|
Personally I'm not a fan of "Cancel Job" there. To me, "cancel" better applies to something which has started or had some kind of work done or planned. It sounds odd for new job tabs (no script selected yet) or even when a script was selected but not other config was made. "Close Job" works reasonably well in all cases. With possibly some tweaks or warnings depending on what it implies on the job's data, when we add persistence. |
Yes, I can see where you're coming from and I don't have a problem with changing it to "Close Job". |
Ok this is sort of a duplicate of #81 regarding using "Close job", so that part is fixed. It might also be a good future idea to use Close window vs close tab (with two different shortcuts), as discussed here, so I'm leaving this issue open but with no milestone. |
Tab-based UIs on macOS usually have a "Close Tab" action in addition to "Close Window". See how it's described in Apple's guidelines.
On macOS I would expect the file menu to have:
It is related to general tab/name/window relationship (see also #83).
If a job's lifecycle is tied to its tab, then the "Cancel job" action is the same as "Close tab", right? "Cancel job" does kinda sound odd to me when the job is not running btw.
The text was updated successfully, but these errors were encountered: