Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-select first menu item #186

Open
marisademeglio opened this issue Feb 5, 2024 · 6 comments
Open

Auto-select first menu item #186

marisademeglio opened this issue Feb 5, 2024 · 6 comments

Comments

@marisademeglio
Copy link
Member

From recent tester feedback:

"when open any menu, first menu item inside the menu should be selected"

@marisademeglio
Copy link
Member Author

Is this standard behavior on Windows? @NPavie can you see what happens by default if you alt-F to the file menu in the Pipeline? On mac, the Pipeline behavior matches other native apps, e.g. mac Mail.

@NPavie
Copy link
Collaborator

NPavie commented Feb 13, 2024

@marisademeglio i checked on several app, and it depends :

  • on Chrome (and chrome-based app that have menus), indeed no menu item are selected by default when opening menus
  • but on Microsoft applications (including edge, VSCode, but also word, visual studio community), the first item is automatically selected on opening the menu

I assume that on Windows, on activating the menu, we will need to manually set focus on the first element on opening.

i'll look into that in the app.

@NPavie
Copy link
Collaborator

NPavie commented Feb 13, 2024

hum this issue might be a bit difficult to solve

I did not find a way so far to force the focus on the first element of the opening menu on opening the menu.

I might look at how vscode does it but i think they overloaded the menu bar creation.

@NPavie
Copy link
Collaborator

NPavie commented Feb 13, 2024

Opened an issue regarding this in electron/electron#41324

@NPavie
Copy link
Collaborator

NPavie commented Feb 22, 2024

I did some experiment on electron dev requests as they were not able to reproduce the issue right away and reported to them the results:
It seems this selection issue happens when the focus or the mouse is on the web view.

When selecting the application outside the web view (like by switching to the app with alt-tab), the first item of the menu is correctly selected on opening the menu.

@avneeshsingh
Copy link

The deadline for final deliverable is close. So, it is OK to defer such minor issues that are taking considerable time. These can be fixed in future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants