-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options defined in CSS style sheets get a plain text field while they should get a dropdown list or number field #246
Comments
The
|
This is due to a change that I forgot to mention (or maybe I thought it didn't matter because of certain assumptions I made about the GUI). Actually the type attribute is not wrong. But while before, the value would always be either a predefined type (string/boolean/integer/etc.), or the ID of a type contained in the static list of data types that you could fetch with a single The data type definition is temporarily made available through |
Ah ok ... While we do look up custom datatypes by ID: The actual fetching of all datatypes happens all at once (every 1000ms): Would this temporary custom datatype be available at the |
It's not available at the |
Also improve numeric field options to distinguish float vs int, integer vs non-neg integer
Development note: I wanted to fetch the temp datatype from the main process but the IPC communication is not robust enough to prevent mixed messages on the front end (literally: one component listening for an IPC fetch response will hear the response of the fetch that another component requested, because the events are using the same channel name). So I used the in-browser fetch, which works because we start the pipeline with CORS disabled, but this is not necessarily always the case, e.g. with hypothetical remote pipeline engine configs. Not sure if there's a way to use dynamic channel names, @NPavie any ideas? |
Seems to not throw lifecycle errors anymore
This worked fine in 1.5.0-beta.1.
For example:
In the CLI it still looks correct:
The text was updated successfully, but these errors were encountered: