Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Warning when using with the GitHub Action: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1) #1471

Open
amakhrov opened this issue Jan 21, 2025 · 0 comments
Labels

Comments

@amakhrov
Copy link

amakhrov commented Jan 21, 2025

Describe the bug

As per the the docs, we're using the danger/danger-js GHA action (docker-based) for running the checks in CI without installing Yarn.
It prints the warnings

Build container for action use: '/home/runner/_work/_actions/danger/danger-js/92d2525fe338bff16ae7d42794d0a835e2d27473/Dockerfile'.
  /usr/bin/docker build -t 079b50:eead83866dcc40a99e8beb9b679b5b8a -f "/home/runner/_work/_actions/danger/danger-js/92d2525fe338bff16ae7d42794d0a835e2d27473/Dockerfile" "/home/runner/_work/_actions/danger/danger-js/92d2525fe338bff16ae7d42794d0a835e2d27473"

...

2 warnings found (use docker --debug to expand):
   - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 11)
   - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)

Workflow:

jobs:
  danger:
    runs-on: ubuntu
    steps:
      - name: Checkout repo
        uses: actions/[email protected]
      - name: Run Danger JS
        uses: danger/danger-js@92d2525fe338bff16ae7d42794d0a835e2d27473 # v12.3.3
        env:
          DANGER_GITHUB_API_TOKEN: ${{ secrets.CI_GITHUB_TOKEN }}

To Reproduce

Steps to reproduce the behavior:

  1. Run the workflow in GHA
  2. Observe the warnings above; the workflow fails

Expected behavior

The Docker container should build successfully and the workflow complete without warnings

Your Environment

software version
danger.js v12.3.3
node
npm
Operating System

EDITED
I was mistaken about the error - it's just a warning from GHA - it doesn't actually prevent the workflow from completing.
Still, it would be nice to fix it (sounds simple enough?)

@amakhrov amakhrov added the bug label Jan 21, 2025
@amakhrov amakhrov changed the title [BUG] Error when using with the GitHub Action: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1) [BUG] Warning when using with the GitHub Action: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1) Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant