You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
one thing I am missing is lines_of_code that was available in Ruby version of Danger. It helps to warn reviewers that PR is bigger than is standard or expected, or you can simply force documentation/tests update from certain number of lines like I did in Ruby danger:
# Check if documentation is updateddocumentation_warning=10documentation_error=30documentation_message="Documentation was not updated. Any change should be reflected in DCS."# Skip if is trivialifhas_app_changes && !has_documentation_changeswarndocumentation_messageifgit.lines_of_code >= documentation_warning && (git.lines_of_code < documentation_error || is_trivial)faildocumentation_messageifgit.lines_of_code >= documentation_error && !is_trivialend
The text was updated successfully, but these errors were encountered:
Hello,
one thing I am missing is
lines_of_code
that was available in Ruby version of Danger. It helps to warn reviewers that PR is bigger than is standard or expected, or you can simply force documentation/tests update from certain number of lines like I did in Ruby danger:The text was updated successfully, but these errors were encountered: