Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails if many warnings #604

Closed
LarsJK opened this issue May 26, 2018 · 2 comments
Closed

Fails if many warnings #604

LarsJK opened this issue May 26, 2018 · 2 comments

Comments

@LarsJK
Copy link

LarsJK commented May 26, 2018

It seems like the json between the processes can grow to large.

if I run something like this:

import { warn } from "danger";

for (let i = 0; i < 200; i++) {
    warn('Some warning!');
}

It fails with this error:
Error: Error: Results passed to Danger JS did not include fails.

Looks like the JSON is cut of and parsed to {}

@orta
Copy link
Member

orta commented May 26, 2018

This is likely a dupe of #603

@LarsJK
Copy link
Author

LarsJK commented May 26, 2018

Yes it's a dupe. I'll close this and follow 603 instead!

@LarsJK LarsJK closed this as completed May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants