Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requested_reviewers return incorrect shape #702

Open
derrickpelletier opened this issue Oct 18, 2018 · 2 comments
Open

requested_reviewers return incorrect shape #702

derrickpelletier opened this issue Oct 18, 2018 · 2 comments

Comments

@derrickpelletier
Copy link

I'm on 4.4.8

Danger looks like it's getting the wrong shape for danger.github.requested_reviewers
When i log this out, i'm seeing:

{ users: [], teams: [] }

So when trying to reference user count, i'm getting TS errors.

@orta
Copy link
Member

orta commented Oct 19, 2018

It's more likely that the shape of the API has changed from GitHub, so yeah, this'll need type updates in danger and danger-swift I bet

@freddy5566
Copy link

freddy5566 commented Jan 23, 2019

Hi, @orta

Does it fix? Cause I also encounter this issue

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants