New language support : C#

[ldubrois]

I've started using Danger on our Gitlab repository but in my team we are mainly C# developers and ruby is not well known by us.

I would like to provide a.net core implementation of Danger. Does it make sense to you?

What will be for you the first step to begins smoothly?

Thanks.

[orta]

It makes perfect sense - assuming you're building it in C#, I've created a repo: https://github.com/danger/csharp

My C# skills are pretty rusty (been about 10 years) so I can only be so useful. I have a document specifically on how to build a language runner: https://danger.systems/js/usage/danger-process.html

Roughly: danger-js will send a JSON payload of the DSL, you convert that DSL into types in C# ( this might help ) and find a way to execute/eval code with those set up at runtime. You then need to console.log out a file path for danger-js to pick up the results json from once your app's process has finished

[orta]

I can help out with CI etc, and if it's there's a way for me to run on mono / macOS I can try help out too

[orta]

And finally, I think this is generally a useful checklist of things you can aim for to make a complete implementation: danger/swift#67

[orta]

Ah, yeah, that relies on GitLab support existing in danger-js, which doesn't exist yet: #396

But that's still way less effort than building all of the communications/reporting/CI/commands

[ldubrois]

Sorry for my late answer.

I've take a look on the different link you proposed, thanks for it.

I will have to check if C# parser and on the fly compiler are available on .net core (which is officlial supported on linux, mac, and of course windows), otherwise I will have to use the full .net framework which is only available on Windows (and check with Mono).

[orta]

Did this get anywhere? Gitlab has been added since

[acherkashin]

@orta any updates on C# implementation? It seems, C# repository has been removed.

[orta]

Pretty sure no-one worked on it, you're welcome to start it up

…

On Wed, Jan 26, 2022, at 9:35 AM, Cherkashin Alexander wrote: @orta <https://github.com/orta> any updates on C# implementation? It seems, C# <https://github.com/danger/csharp> repository has been removed. — Reply to this email directly, view it on GitHub <#757 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAL7DUUMKEKMWX5MZ77SZLUX654XANCNFSM4GCISVFA>. You are receiving this because you were mentioned.Message ID: ***@***.***>