Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way for dangerfile to detect whether is running on CI #811

Open
stellarhoof opened this issue Jan 24, 2019 · 5 comments
Open

A way for dangerfile to detect whether is running on CI #811

stellarhoof opened this issue Jan 24, 2019 · 5 comments
Labels
enhancement You Can Do This This idea is well spec'd and ready for a PR

Comments

@stellarhoof
Copy link

We've got rules that make sense to only run when on CI. Currently there's no way of detecting this without duplicating the logic danger already uses to detect if it's running in CI.

When I say CI I mean real CI, not the fake one. Perhaps this information could be exposed under danger.utils ?

@orta
Copy link
Member

orta commented Jan 24, 2019

Yeah, that makes sense danger.utils.info.isCI maybe? Then we can add something like isGitHub, or isLocal later on

@orta orta added enhancement You Can Do This This idea is well spec'd and ready for a PR labels Jan 24, 2019
@stellarhoof
Copy link
Author

stellarhoof commented Jan 24, 2019

I'd say danger.utils.info.ci.*, so we've got a nice namespace there. What does the "You Can Do This" tag mean? That is easy to contribute on this issue?

@orta
Copy link
Member

orta commented Jan 25, 2019

I'm cool with that - it means someone doesn't have to feel blocked on implementing because we agree on the general idea 👍

@milesj
Copy link

milesj commented Aug 19, 2019

@orta
Copy link
Member

orta commented Aug 20, 2019

Yep good point, you're welcome to use that in your Dangerfiles - I'd rather not have a new dependency in Danger unless it provides something really new and useu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement You Can Do This This idea is well spec'd and ready for a PR
Projects
None yet
Development

No branches or pull requests

3 participants