Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to run inline tests #825

Open
orta opened this issue Feb 7, 2019 · 0 comments
Open

Figure out how to run inline tests #825

orta opened this issue Feb 7, 2019 · 0 comments

Comments

@orta
Copy link
Member

orta commented Feb 7, 2019

I think that Jest is breaking my changes to global between test runs, not a problem in vm2 (I think it uses eval) but when creating a new module and compiling it global is reset.

This is less of an issue in danger, but much more of an issue in Peril.

Perhaps in tests we could not edit globals and use jest.mock on a "danger" import?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orta