Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override the unhandledRejection handler #828

Open
mgol opened this issue Feb 14, 2019 · 0 comments
Open

Allow to override the unhandledRejection handler #828

mgol opened this issue Feb 14, 2019 · 0 comments

Comments

@mgol
Copy link
Contributor

mgol commented Feb 14, 2019

DangerJS specifies an unhandledRejection handler that makes the process finish with an error code.

In our team some of our Danger checks fail for reasons unrelated to the PR reported; for example, some GitHub API endpoint failed or there's a logic error in the checking code. These cases make Danger fail the build and, hence, disallows the PR from being merged.

I'd like to be able to override the behavior so that errors in the checker code are only producing warnings for other people to look at but that wouldn't prevent PRs from being merged. Would adding such a customization be possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant