Errors when returns forms

[Hamito51]

There are several problems with forms.

1. The first issue takes place, when I want to update existing object. For example, I want to update field in our forms. I have emailField, but I put in the field something different. When I click save, there is no validation error "Enter a valid email address." I get template error with key error.
2. The same thing happens while I tried to create new object, but don't include some field in "inline_reverse" fields. I can see error "This field is required" but only via debug in _errors method. In the browser I get same template with key error.
3. I have several OneToOneFields, I make mistake with filling fields, like in first example, I mistake with emailField format, I successfully get validation error and browser suggest me to edit this field, but if other fields(from another OneToOne form) were empty I won't get this forms to fill

[BrettMeirhofer]

I can confirm 1. Whenever there is an validation error with the reverse_inline formfields it will often result in a KeyError instead of a proper django ValidationError. It's hard to reproduce though since it seems to only happen to specific fields and doesn't happen if another field also has an error.

[AndrewPix]

1. can be easily reproduced if you set regular inlines tuple within inline_reverse in one admin config. I am using django 3.2

[zakum1]

I am using Django 4.0.1 and this happens consistently if there are any inline_reverse entries:

class MyAdmin(ReverseModelAdmin):
  inlines = [ ... ]
  inline_type = 'stacked'
  inline_reverse = ['field1', 'field2', 'field3']

In this scenario, I get a key error if any field anywhere in the form that is required is not provided

The field, field2 and field3 are OneToOne relationsips:

    field1 = models.OneToOneField(to=OtherModel, on_delete=models.CASCADE, null=True, blank=True, related_name='field1')

[abdul-hamid-achik]

for anyone interested, the issue seems to be this:

django_reverse_admin/django_reverse_admin/__init__.py

Line 204 in babdfd4

return own + super(ReverseModelAdmin, self).get_inline_instances(request, obj)

and there seems to be a fix for this here #286

[abdul-hamid-achik]

guys that, needs to be changed to:

    def get_inline_instances(self, request, obj=None):
        own = list(filter(
            lambda inline: inline.has_view_or_change_permission(request, obj) or
            inline.has_add_permission(request, obj) or
            inline.has_delete_permission(request, obj), self.tmp_inline_instances))
        return super(ReverseModelAdmin, self).get_inline_instances(request,
                                                                    obj) + own

the own inline instances need to be at the bottom otherwise, its never gonna match the right fields