Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify expand up/down arrows #193

Open
danvk opened this issue Jun 8, 2024 · 0 comments
Open

Clarify expand up/down arrows #193

danvk opened this issue Jun 8, 2024 · 0 comments
Milestone

Comments

@danvk
Copy link
Owner

danvk commented Jun 8, 2024

Here's webdiff now:

image

"Show 228 more lines" is clear, but the up/down arrows are not. Here's pullrequest.com, by comparison:

image

Here's how Reviewable handles it. I find this extremely clear! Including a zero-line bar at the end of the file is clever.

image

Now that this is all in React, it should be easier to make the UI taller.

@danvk danvk modified the milestones: 1.2.0, 1.3.0 Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant