Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip over more lines in diffhunk selection #210

Open
danvk opened this issue Jun 13, 2024 · 0 comments
Open

Skip over more lines in diffhunk selection #210

danvk opened this issue Jun 13, 2024 · 0 comments

Comments

@danvk
Copy link
Owner

danvk commented Jun 13, 2024

The diffhunk selection from #200 is functional but leaves a bit to be desired:

  • Deleted diffhunks show a selection line both above and below the diffhunk (should only be above)
  • When webdiff adds more context (e.g. to enforce minJumpSize), you can select the line where it did this. This looks weird and is non-sensical.
  • Selection on top line is not displayed.
  • It should be possible to select the bottom line.
  • Hitting n at the bottom of the file should advance to the next file.
  • Hitting p at the top of the file should move to the previous file.
  • When you click an up/down arrow to show more context, the "seam" is still selectable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant