Skip to content

Commit ee84b88

Browse files
committed
fix: docs based on review comments
1 parent 7cecdfe commit ee84b88

File tree

1 file changed

+9
-8
lines changed
  • daprdocs/content/en/reference/components-reference/supported-locks

1 file changed

+9
-8
lines changed

daprdocs/content/en/reference/components-reference/supported-locks/redis-lock.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ The above example uses secrets as plain strings. It is recommended to use a secr
8686
| maxRetryBackoff | N | Maximum backoff between each retry. Defaults to `2` seconds; `"-1"` disables backoff. | `3000000000` |
8787
| failover | N | Enable failover configuration. Needs sentinelMasterName to be set. The redisHost should be the sentinel host address. See [Redis Sentinel Documentation](https://redis.io/docs/manual/sentinel/). Defaults to `"false"` | `"true"`, `"false"` |
8888
| sentinelMasterName | N | The sentinel master name. See [Redis Sentinel Documentation](https://redis.io/docs/manual/sentinel/) | `"mymaster"` |
89-
| sentinelPassword | N | Password for Redis sentinel. No Default. Can be `secretKeyRef` to use a secret reference | `""`, `"KeFg23!"`
89+
| sentinelPassword | N | Password for Redis Sentinel. No Default. Applicable only when “failover” is true, and Redis Sentinel has authentication enabled | `""`, `"KeFg23!"`
9090
| redeliverInterval | N | The interval between checking for pending messages for redelivery. Defaults to `"60s"`. `"0"` disables redelivery. | `"30s"` |
9191
| processingTimeout | N | The amount of time a message must be pending before attempting to redeliver it. Defaults to `"15s"`. `"0"` disables redelivery. | `"30s"` |
9292
| redisType | N | The type of redis. There are two valid values, one is `"node"` for single node mode, the other is `"cluster"` for redis cluster mode. Defaults to `"node"`. | `"cluster"` |
@@ -183,17 +183,18 @@ You can use [Helm](https://helm.sh/) to quickly create a Redis instance in our K
183183
{{< /tabpane >}}
184184

185185

186-
## Redis Sentinel Behavior
186+
## Redis Sentinel behavior
187187

188188
Use `redisType: "node"` when connecting to Redis Sentinel. Additionally, set `failover` to `"true"` and `sentinelMasterName` to the name of the master node.
189189

190-
**Failover Characteristics:**
191-
- **Lock Loss During Failover**: Locks may be lost during master failover if they weren't replicated to the promoted replica before the original master failed
192-
- **Failover Window**: Brief unavailability (typically seconds) during automatic master promotion
193-
- **Consistency**: All operations route to the current master, maintaining lock consistency
194-
- **Trade-off**: High availability vs. potential lock loss during failover events
190+
Failover characteristics:
191+
- Lock loss during failover: Locks may be lost during master failover if they weren't replicated to the promoted replica before the original master failed
192+
- Failover window: Brief server unavailability (typically seconds) during automatic master promotion
193+
- Consistency: All operations route to the current master, maintaining lock consistency
195194

196-
⚠️ **Important**: Consider your application's tolerance for brief lock loss during failover scenarios.
195+
{{% alert title="Warning" color="warning" %}}
196+
Consider the trade-off of running Redis with high-availability and failover with the potential of lock loss during failover events. Your application should tolerate brief lock loss during failover scenarios.
197+
{{% /alert %}}
197198

198199
## Related links
199200
- [Basic schema for a Dapr component]({{% ref component-schema %}})

0 commit comments

Comments
 (0)