Fix integration test retry extension (microsoft#227)

* Fix integration test retry extension

The integration tests were using a retry extension that was
eating exceptions and hiding failures. This commit removes
the customer extension and relies on gradle's built in retry.

Signed-off-by: Hal Spang <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>

Author: halspang

client/build.gradle

@@ -7,6 +7,7 @@ plugins {
 //    id 'signing'
     id 'com.github.spotbugs' version '5.2.1'
     id 'org.jreleaser' version '1.18.0'
+    id 'org.gradle.test-retry' version '1.4.1'
 }
 
 group 'io.dapr'
@@ -122,6 +123,11 @@ test {
         // and require external dependencies.
         excludeTags "integration"
     }
+    
+    retry {
+        maxRetries = 2
+        maxFailures = 5
+    }
 }
 
 // Unlike normal unit tests, some tests are considered "integration tests" and shouldn't be
@@ -137,6 +143,12 @@ task integrationTest(type: Test) {
     testLogging.showStandardStreams = true
 
     ignoreFailures = false
+    
+    // Add retry capability for flaky integration tests
+    retry {
+        maxRetries = 3
+        maxFailures = 10
+    }
 }
 
 publishing {

client/src/test/java/io/dapr/durabletask/ErrorHandlingIntegrationTests.java

@@ -7,7 +7,6 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
-import org.junit.jupiter.api.extension.ExtendWith;
 
 import java.time.Duration;
 import java.util.concurrent.TimeoutException;
@@ -25,15 +24,16 @@
  * client operations and sends invocation instructions to the DurableTaskWorker).
  */
 @Tag("integration")
-@ExtendWith(TestRetryExtension.class)
 public class ErrorHandlingIntegrationTests extends IntegrationTestBase {
+
     @BeforeEach
     private void startUp() {
-        DurableTaskClient client = new DurableTaskGrpcClientBuilder().build();
-        client.deleteTaskHub();
+        try(DurableTaskClient client = new DurableTaskGrpcClientBuilder().build()) {
+            client.deleteTaskHub();
+        }
     }
 
-    @RetryingTest
+    @Test
     void orchestratorException() throws TimeoutException {
         final String orchestratorName = "OrchestratorWithException";
         final String errorMessage = "Kah-BOOOOOM!!!";
@@ -59,7 +59,7 @@ void orchestratorException() throws TimeoutException {
         }
     }
 
-    @RetryingParameterizedTest
+    @ParameterizedTest
     @ValueSource(booleans = {true, false})
     void activityException(boolean handleException) throws TimeoutException {
         final String orchestratorName = "OrchestratorWithActivityException";
@@ -111,7 +111,7 @@ void activityException(boolean handleException) throws TimeoutException {
         }
     }
 
-    @RetryingParameterizedTest
+    @ParameterizedTest
     @ValueSource(ints = {1, 2, 10})
     public void retryActivityFailures(int maxNumberOfAttempts) throws TimeoutException {
         // There is one task for each activity call and one task between each retry
@@ -125,7 +125,7 @@ public void retryActivityFailures(int maxNumberOfAttempts) throws TimeoutExcepti
         });
     }
 
-    @RetryingParameterizedTest
+    @ParameterizedTest
     @ValueSource(ints = {1, 2, 10})
     public void retryActivityFailuresWithCustomLogic(int maxNumberOfAttempts) throws TimeoutException {
         // This gets incremented every time the retry handler is invoked
@@ -142,7 +142,7 @@ public void retryActivityFailuresWithCustomLogic(int maxNumberOfAttempts) throws
         assertEquals(maxNumberOfAttempts, retryHandlerCalls.get());
     }
 
-    @RetryingParameterizedTest
+    @ParameterizedTest
     @ValueSource(booleans = {true, false})
     void subOrchestrationException(boolean handleException) throws TimeoutException {
         final String orchestratorName = "OrchestrationWithBustedSubOrchestrator";
@@ -192,7 +192,7 @@ void subOrchestrationException(boolean handleException) throws TimeoutException
         }
     }
 
-    @RetryingParameterizedTest
+    @ParameterizedTest
     @ValueSource(ints = {1, 2, 10})
     public void retrySubOrchestratorFailures(int maxNumberOfAttempts) throws TimeoutException {
         // There is one task for each sub-orchestrator call and one task between each retry
@@ -207,7 +207,7 @@ public void retrySubOrchestratorFailures(int maxNumberOfAttempts) throws Timeout
             });
     }
 
-    @RetryingParameterizedTest
+    @ParameterizedTest
     @ValueSource(ints = {1, 2, 10})
     public void retrySubOrchestrationFailuresWithCustomLogic(int maxNumberOfAttempts) throws TimeoutException {
         // This gets incremented every time the retry handler is invoked